Skip to content

Commit 909ee7a

Browse files
committed
feat(ui): bump mod-arch packages to 1.15.3 and use McpCatalogIcon
- Bump mod-arch-core, mod-arch-kubeflow, and mod-arch-shared from ~1.12.0 to ~1.15.3 - Use ProjectObjectType.mcpCatalog instead of ProjectObjectType.modelCatalog in MCP Catalog pages so they render the dedicated McpCatalogIcon - Add mod-arch-shared/dist and mod-arch-kubeflow/dist as fallback paths for the ~ webpack alias to work around unresolved tsc-alias paths in the 1.15.3 release Assisted-by: Claude Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> Made-with: Cursor Signed-off-by: manaswinidas <dasmanaswini10@gmail.com> Made-with: Cursor
1 parent c17f5f5 commit 909ee7a

6 files changed

Lines changed: 33 additions & 25 deletions

File tree

clients/ui/frontend/config/webpack.common.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,11 @@ module.exports = (env) => ({
236236
resolve: {
237237
extensions: ['.js', '.ts', '.tsx', '.jsx', '.yaml'],
238238
alias: {
239-
'~': path.resolve(SRC_DIR),
239+
'~': [
240+
path.resolve(SRC_DIR),
241+
path.resolve(__dirname, '../node_modules/mod-arch-shared/dist'),
242+
path.resolve(__dirname, '../node_modules/mod-arch-kubeflow/dist'),
243+
],
240244
// Set SAMPLE_CATALOG_YAML_PATH to override the bundled sample YAML with a custom file at build time.
241245
...(process.env.SAMPLE_CATALOG_YAML_PATH && {
242246
'~/app/pages/modelCatalogSettings/sample-catalog.yaml': path.resolve(

clients/ui/frontend/package-lock.json

Lines changed: 16 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

clients/ui/frontend/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,9 @@
101101
"classnames": "^2.2.6",
102102
"dompurify": "^3.3.2",
103103
"lodash-es": "^4.18.1",
104-
"mod-arch-core": "~1.12.0",
105-
"mod-arch-kubeflow": "~1.12.0",
106-
"mod-arch-shared": "~1.12.0",
104+
"mod-arch-core": "~1.15.3",
105+
"mod-arch-kubeflow": "~1.15.3",
106+
"mod-arch-shared": "~1.15.3",
107107
"react": "^18",
108108
"react-dom": "^18",
109109
"react-markdown": "^10.1.0",

clients/ui/frontend/src/__tests__/cypress/webpack.config.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,11 @@ const webpackConfig = {
55
resolve: {
66
extensions: ['.ts', '.tsx', '.js', '.jsx'],
77
alias: {
8-
'~': path.resolve(__dirname, '../../'),
8+
'~': [
9+
path.resolve(__dirname, '../../'),
10+
path.resolve(__dirname, '../../../node_modules/mod-arch-shared/dist'),
11+
path.resolve(__dirname, '../../../node_modules/mod-arch-kubeflow/dist'),
12+
],
913
},
1014
},
1115
module: {

clients/ui/frontend/src/app/pages/mcpCatalog/McpCatalogCoreLoader.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const McpCatalogCoreLoader: React.FC = () => {
2424
return (
2525
<ApplicationsPage
2626
title={
27-
<TitleWithIcon title={MCP_CATALOG_TITLE} objectType={ProjectObjectType.modelCatalog} />
27+
<TitleWithIcon title={MCP_CATALOG_TITLE} objectType={ProjectObjectType.mcpCatalog} />
2828
}
2929
description={MCP_CATALOG_DESCRIPTION}
3030
headerContent={null}
@@ -45,7 +45,7 @@ const McpCatalogCoreLoader: React.FC = () => {
4545
return (
4646
<ApplicationsPage
4747
title={
48-
<TitleWithIcon title={MCP_CATALOG_TITLE} objectType={ProjectObjectType.modelCatalog} />
48+
<TitleWithIcon title={MCP_CATALOG_TITLE} objectType={ProjectObjectType.mcpCatalog} />
4949
}
5050
description={MCP_CATALOG_DESCRIPTION}
5151
headerContent={null}
@@ -60,7 +60,7 @@ const McpCatalogCoreLoader: React.FC = () => {
6060
return (
6161
<ApplicationsPage
6262
title={
63-
<TitleWithIcon title={MCP_CATALOG_TITLE} objectType={ProjectObjectType.modelCatalog} />
63+
<TitleWithIcon title={MCP_CATALOG_TITLE} objectType={ProjectObjectType.mcpCatalog} />
6464
}
6565
description={MCP_CATALOG_DESCRIPTION}
6666
empty

clients/ui/frontend/src/app/pages/mcpCatalog/screens/McpCatalog.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ const McpCatalog: React.FC = () => {
3737
<ScrollViewOnMount shouldScroll scrollToTop />
3838
<ApplicationsPage
3939
title={
40-
<TitleWithIcon title={MCP_CATALOG_TITLE} objectType={ProjectObjectType.modelCatalog} />
40+
<TitleWithIcon title={MCP_CATALOG_TITLE} objectType={ProjectObjectType.mcpCatalog} />
4141
}
4242
description={MCP_CATALOG_DESCRIPTION}
4343
empty={false}

0 commit comments

Comments
 (0)