fix(bff): port to golangci-lint v2 (#948)

* fix(bff): port to golangci-lint v2

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix(gha): bump golanglint-ci version in action

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

---------

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

Author: Al-Pragliola

.github/workflows/ui-bff-build.yml

@@ -35,7 +35,7 @@ jobs:
       - name: Lint
         uses: golangci/golangci-lint-action@v7
         with:
-          version: v1.63.4
+          version: v2.0.2
           working-directory: clients/ui/bff/
 
       - name: Build

clients/ui/bff/.golangci.yaml

@@ -1,2 +1,20 @@
-run:
-  timeout: 3m
+version: "2"
+linters:
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

clients/ui/bff/Makefile

@@ -64,7 +64,7 @@ ENVTEST ?= $(LOCALBIN)/setup-envtest-$(ENVTEST_VERSION)
 GOLANGCI_LINT ?= $(LOCALBIN)/golangci-lint-$(GOLANGCI_LINT_VERSION)
 
 ## Tool Versions
-GOLANGCI_LINT_VERSION ?= v1.63.4
+GOLANGCI_LINT_VERSION ?= v2.0.2
 ENVTEST_VERSION ?= release-0.17
 
 .PHONY: envtest
@@ -75,7 +75,7 @@ $(ENVTEST): $(LOCALBIN)
 .PHONY: golangci-lint
 golangci-lint: $(GOLANGCI_LINT) ## Download golangci-lint locally if necessary.
 $(GOLANGCI_LINT): $(LOCALBIN)
-	$(call go-install-tool,$(GOLANGCI_LINT),github.com/golangci/golangci-lint/cmd/golangci-lint,${GOLANGCI_LINT_VERSION})
+	$(call go-install-tool,$(GOLANGCI_LINT),github.com/golangci/golangci-lint/v2/cmd/golangci-lint,${GOLANGCI_LINT_VERSION})
 
 
 # go-install-tool will 'go install' any package with custom target and name of binary, if it doesn't exist

clients/ui/bff/internal/integrations/http.go

@@ -4,12 +4,13 @@ import (
 	"crypto/tls"
 	"encoding/json"
 	"fmt"
-	"github.com/google/uuid"
-	helper "github.com/kubeflow/model-registry/ui/bff/internal/helpers"
 	"io"
 	"log/slog"
 	"net/http"
 	"strconv"
+
+	"github.com/google/uuid"
+	helper "github.com/kubeflow/model-registry/ui/bff/internal/helpers"
 )
 
 type HTTPClientInterface interface {
@@ -90,8 +91,8 @@ func (c *HTTPClient) GET(url string) ([]byte, error) {
 		//Sometimes the code comes empty from model registry API
 		//also not all error codes are correctly implemented
 		//see https://github.com/kubeflow/model-registry/issues/95
-		if httpError.ErrorResponse.Code == "" {
-			httpError.ErrorResponse.Code = strconv.Itoa(response.StatusCode)
+		if httpError.Code == "" {
+			httpError.Code = strconv.Itoa(response.StatusCode)
 		}
 		return nil, httpError
 	}
@@ -136,8 +137,8 @@ func (c *HTTPClient) POST(url string, body io.Reader) ([]byte, error) {
 		//Sometimes the code comes empty from model registry API
 		//also not all error codes are correctly implemented
 		//see https://github.com/kubeflow/model-registry/issues/95
-		if httpError.ErrorResponse.Code == "" {
-			httpError.ErrorResponse.Code = strconv.Itoa(response.StatusCode)
+		if httpError.Code == "" {
+			httpError.Code = strconv.Itoa(response.StatusCode)
 		}
 		return nil, httpError
 	}
@@ -182,8 +183,8 @@ func (c *HTTPClient) PATCH(url string, body io.Reader) ([]byte, error) {
 		//Sometimes the code comes empty from model registry API
 		//also not all error codes are correctly implemented
 		//see https://github.com/kubeflow/model-registry/issues/95
-		if httpError.ErrorResponse.Code == "" {
-			httpError.ErrorResponse.Code = strconv.Itoa(response.StatusCode)
+		if httpError.Code == "" {
+			httpError.Code = strconv.Itoa(response.StatusCode)
 		}
 		return nil, httpError
 	}