Skip to content

Commit f0716eb

Browse files
committed
chore: fix marking of async upload job e2e and integration tests
Signed-off-by: Debarati Basu-Nag <dbasunag@redhat.com>
1 parent 85618f5 commit f0716eb

6 files changed

Lines changed: 209 additions & 35 deletions

File tree

.github/workflows/async-upload-test.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@ jobs:
5353
- name: Run tests
5454
run: |
5555
make test
56-
- name: Run E2E tests
56+
- name: Run integration tests
5757
run: |
58-
make test-e2e
58+
make test-integration
5959
job-test:
6060
runs-on: ubuntu-latest
6161
defaults:
@@ -72,7 +72,7 @@ jobs:
7272
pipx install poetry
7373
- name: Execute Sample Job E2E test
7474
run: |
75-
make test-integration
75+
make test-e2e
7676
check-autogen:
7777
name: Check generated code or files are in sync
7878
runs-on: ubuntu-latest

jobs/async-upload/Makefile

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ test-with-cov:
4646
poetry run pytest --cov=job --cov-report=term-missing tests/
4747

4848
.PHONY: test-e2e
49-
test-e2e: deploy-latest-mr deploy-local-registry deploy-test-minio
49+
test-e2e: deploy-latest-mr deploy-local-registry deploy-test-minio dev-load-image
5050
@echo "Starting test-e2e"
5151
@set -e; \
5252
$(MAKE) test-e2e-run || TEST_STATUS=$$?; \
@@ -60,9 +60,9 @@ test-e2e: deploy-latest-mr deploy-local-registry deploy-test-minio
6060
.PHONY: test-e2e-run
6161
test-e2e-run:
6262
@echo "Ensuring all extras are installed..."
63-
poetry install --all-extras
64-
@echo "Running tests..."
65-
poetry run pytest --e2e -s -x -rA
63+
poetry install --all-extras --with integration
64+
@echo "Running e2e tests..."
65+
CONTAINER_IMAGE_URI=$(JOB_IMG) poetry run pytest --e2e tests/integration/ -vs
6666

6767
.PHONY: test-e2e-cleanup
6868
test-e2e-cleanup:
@@ -73,7 +73,7 @@ test-e2e-cleanup:
7373
fi
7474

7575
.PHONY: test-integration
76-
test-integration: deploy-latest-mr deploy-local-registry deploy-test-minio dev-load-image
76+
test-integration: deploy-latest-mr deploy-local-registry deploy-test-minio
7777
@echo "Starting test-integration"
7878
@set -e; \
7979
$(MAKE) test-integration-run || TEST_STATUS=$$?; \
@@ -87,9 +87,9 @@ test-integration: deploy-latest-mr deploy-local-registry deploy-test-minio dev-l
8787
.PHONY: test-integration-run
8888
test-integration-run:
8989
@echo "Ensuring all extras are installed..."
90-
poetry install --all-extras --with integration
90+
poetry install --all-extras
9191
@echo "Running integration tests..."
92-
CONTAINER_IMAGE_URI=$(JOB_IMG) poetry run pytest --integration tests/integration/ -vs
92+
poetry run pytest --integration -s -x -rA
9393

9494
.PHONY: install
9595
install: install-poetry-export

0 commit comments

Comments
 (0)