Merge branch 'main' into fix/podutils-inverted-condition-and-rpc-kfp-loop

Author: ai-naymul

.github/workflows/release.yml

@@ -282,3 +282,4 @@ jobs:
           title: "Bump dev version to ${{ steps.next.outputs.next }}"
           body: "Automated version bump after releasing v${{ needs.prepare.outputs.version }}."
           committer: "github-actions[bot] <github-actions[bot]@users.noreply.github.com>"
+          signoff: true

kale/__init__.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-__version__ = "2.0.0a4"
+__version__ = "2.0.0a5"
 
 from typing import Any, NamedTuple
 

labextension/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jupyterlab-kubeflow-kale",
-  "version": "2.0.0-alpha.4",
+  "version": "2.0.0-alpha.5",
   "description": "Convert Notebooks to Kubeflow pipelines with Kale",
   "keywords": [
     "jupyter",

labextension/src/lib/NotebookUtils.tsx

@@ -259,13 +259,8 @@ export default class NotebookUtilities {
       );
     }
 
-    if (notebookPanel.model?.metadata) {
-      const metadata = notebookPanel.model.metadata as any;
-      if (typeof metadata.has === 'function' && metadata.has(key)) {
-        return metadata.get(key);
-      }
-      // Fallback for different metadata implementations
-      return metadata[key] || null;
+    if (notebookPanel.model) {
+      return notebookPanel.model.getMetadata(key) || null;
     }
     return null;
   }
@@ -292,20 +287,12 @@ export default class NotebookUtilities {
       );
     }
 
-    if (!notebookPanel.model?.metadata) {
-      throw new Error('Notebook metadata is not available.');
+    if (!notebookPanel.model) {
+      throw new Error('Notebook model is not available.');
     }
 
-    const metadata = notebookPanel.model.metadata as any;
-    let oldVal: any;
-
-    if (typeof metadata.set === 'function') {
-      oldVal = metadata.set(key, value);
-    } else {
-      // Fallback for different metadata implementations
-      oldVal = (metadata as any)[key];
-      (metadata as any)[key] = value;
-    }
+    const oldVal = notebookPanel.model.getMetadata(key);
+    notebookPanel.model.setMetadata(key, value);
 
     if (save) {
       this.saveNotebook(notebookPanel);

labextension/src/widgets/LeftPanel.tsx

@@ -478,6 +478,10 @@ export class KubeflowKaleLeftPanel extends React.Component<IProps, IState> {
   };
 
   onPanelRemove = (index: number) => {
+    const deploy = this.state.deploys[index];
+    if (deploy === undefined || deploy === null) {
+      return;
+    }
     const deploys = { ...this.state.deploys };
     deploys[index].deleted = true;
     this.setState({ deploys });