fixed the access mode values

Signed-off-by: kunal-511 <[email protected]>

Author: kunal-511

tests/gh-actions/test_volumes_web_application.sh

@@ -18,52 +18,27 @@ curl --fail --show-error \
   -H "Authorization: Bearer ${TOKEN}" \
   -H "X-XSRF-TOKEN: $XSRFTOKEN" -H "Cookie: XSRF-TOKEN=$XSRFTOKEN"
 
-echo "Attempting to create test-pvc..."
-RESPONSE=$(curl -v -X POST \
+echo "Creating test-pvc..."
+curl --fail --show-error -X POST \
   "localhost:8080/volumes/api/namespaces/${KF_PROFILE}/pvcs" \
   -H "Authorization: Bearer ${TOKEN}" \
   -H "Content-Type: application/json" \
   -H "X-XSRF-TOKEN: $XSRFTOKEN" -H "Cookie: XSRF-TOKEN=$XSRFTOKEN" \
   -d "{
     \"name\": \"test-pvc\",
     \"namespace\": \"${KF_PROFILE}\",
-    \"spec\": {
-      \"accessModes\": [\"ReadWriteOnce\"],
-      \"resources\": {
-        \"requests\": {
-          \"storage\": \"1Gi\"
-        }
-      },
-      \"storageClassName\": \"${STORAGE_CLASS_NAME}\"
-    }
-  }" 2>&1)
-
-echo "Response from PVC creation attempt:"
-echo "$RESPONSE"
-
-if [[ "$RESPONSE" == *"400"* ]]; then
-  echo "First attempt failed with 400 error, trying alternative format..."
-  curl --fail --show-error -X POST \
-    "localhost:8080/volumes/api/namespaces/${KF_PROFILE}/pvcs" \
-    -H "Authorization: Bearer ${TOKEN}" \
-    -H "Content-Type: application/json" \
-    -H "X-XSRF-TOKEN: $XSRFTOKEN" -H "Cookie: XSRF-TOKEN=$XSRFTOKEN" \
-    -d "{
-      \"name\": \"test-pvc\",
-      \"namespace\": \"${KF_PROFILE}\",
-      \"type\": \"new\",
-      \"mode\": \"rwo\",
-      \"size\": \"1Gi\",
-      \"class\": \"${STORAGE_CLASS_NAME}\"
-    }"
-fi
+    \"type\": \"new\",
+    \"mode\": \"ReadWriteOnce\",
+    \"size\": \"1Gi\",
+    \"class\": \"${STORAGE_CLASS_NAME}\"
+  }"
 
 curl --fail --show-error \
   "localhost:8080/volumes/api/namespaces/${KF_PROFILE}/pvcs" \
   -H "Authorization: Bearer ${TOKEN}" \
   -H "X-XSRF-TOKEN: $XSRFTOKEN" -H "Cookie: XSRF-TOKEN=$XSRFTOKEN"
 
-UNAUTHORIZED_STATUS=$(curl --fail --silent --show-error -o /dev/null -w "%{http_code}" \
+UNAUTHORIZED_STATUS=$(curl --silent --output /dev/null -w "%{http_code}" \
   "localhost:8080/volumes/api/namespaces/${KF_PROFILE}/pvcs" \
   -H "Authorization: Bearer ${UNAUTHORIZED_TOKEN}")
 [[ "$UNAUTHORIZED_STATUS" == "403" ]] || exit 1
@@ -78,33 +53,30 @@ curl --fail --show-error -X POST \
     \"name\": \"api-created-pvc\",
     \"namespace\": \"${KF_PROFILE}\",
     \"type\": \"new\",
-    \"mode\": \"rwo\",
+    \"mode\": \"ReadWriteOnce\",
     \"size\": \"1Gi\",
     \"class\": \"${STORAGE_CLASS_NAME}\"
-  }" > /dev/null
+  }"
 
-curl --fail --show-error -X DELETE \
+echo "Testing unauthorized deletion..."
+UNAUTH_DELETE_STATUS=$(curl --silent --output /dev/null -w "%{http_code}" -X DELETE \
   "localhost:8080/volumes/api/namespaces/${KF_PROFILE}/pvcs/test-pvc" \
   -H "Authorization: Bearer ${UNAUTHORIZED_TOKEN}" \
-  -H "X-XSRF-TOKEN: $XSRFTOKEN" -H "Cookie: XSRF-TOKEN=$XSRFTOKEN" || true
+  -H "X-XSRF-TOKEN: $XSRFTOKEN" -H "Cookie: XSRF-TOKEN=$XSRFTOKEN")
+[[ "$UNAUTH_DELETE_STATUS" == "403" ]] || echo "Warning: Unexpected status code for unauthorized delete: $UNAUTH_DELETE_STATUS"
 
 if ! kubectl get pvc test-pvc -n $KF_PROFILE > /dev/null 2>&1; then
-  UNAUTHORIZED_DELETE_RESPONSE=$(curl --fail --silent --show-error \
-    "localhost:8080/volumes/api/namespaces/${KF_PROFILE}/pvcs/test-pvc" \
-    -H "Authorization: Bearer ${TOKEN}" \
-    -H "X-XSRF-TOKEN: $XSRFTOKEN" -H "Cookie: XSRF-TOKEN=$XSRFTOKEN")
-  if [[ "$UNAUTHORIZED_DELETE_RESPONSE" == *"not found"* || "$UNAUTHORIZED_DELETE_RESPONSE" == *"\"code\":404"* ]]; then
-    echo "ERROR: PVC was deleted by unauthorized request or is missing"
-    exit 1
-  fi
+  echo "ERROR: PVC 'test-pvc' not found after unauthorized deletion attempt"
+  exit 1
 fi
 
+echo "Deleting test-pvc with authorized request..."
 curl --fail --show-error -X DELETE \
   "localhost:8080/volumes/api/namespaces/${KF_PROFILE}/pvcs/test-pvc" \
   -H "Authorization: Bearer ${TOKEN}" \
   -H "X-XSRF-TOKEN: $XSRFTOKEN" -H "Cookie: XSRF-TOKEN=$XSRFTOKEN"
 
-DELETE_STATUS=$(curl --fail --silent --show-error -o /dev/null -w "%{http_code}" \
+DELETE_STATUS=$(curl --silent --output /dev/null -w "%{http_code}" \
   "localhost:8080/volumes/api/namespaces/${KF_PROFILE}/pvcs/test-pvc" \
   -H "Authorization: Bearer ${TOKEN}" \
   -H "X-XSRF-TOKEN: $XSRFTOKEN" -H "Cookie: XSRF-TOKEN=$XSRFTOKEN")
@@ -113,6 +85,15 @@ DELETE_STATUS=$(curl --fail --silent --show-error -o /dev/null -w "%{http_code}"
   exit 1
 }
 
-kubectl get pvc test-pvc -n $KF_PROFILE 2>/dev/null && exit 1
+kubectl get pvc test-pvc -n $KF_PROFILE 2>/dev/null && {
+  echo "ERROR: PVC 'test-pvc' still exists after deletion"
+  exit 1
+} || true
+
+echo "Cleaning up api-created-pvc..."
+curl --fail --show-error -X DELETE \
+  "localhost:8080/volumes/api/namespaces/${KF_PROFILE}/pvcs/api-created-pvc" \
+  -H "Authorization: Bearer ${TOKEN}" \
+  -H "X-XSRF-TOKEN: $XSRFTOKEN" -H "Cookie: XSRF-TOKEN=$XSRFTOKEN"
 
 echo "Test completed successfully!"