Adjust sample async job (#1293)

* docs(async-job): add example async job that uses mounted secret

Signed-off-by: Eric Dobroveanu <[email protected]>

* docs(async-job): add sample using args instead of env

Signed-off-by: Eric Dobroveanu <[email protected]>

* docs(async-job): add kitchen sink example

Signed-off-by: Eric Dobroveanu <[email protected]>

* chore: adjust sampel to be representitive of typical use case

Signed-off-by: Eric Dobroveanu <[email protected]>

* chore: move AWS key in sample to the correct place

Signed-off-by: Eric Dobroveanu <[email protected]>

---------

Signed-off-by: Eric Dobroveanu <[email protected]>

Author: Crazyglue

jobs/async-upload/samples/sample_job_s3_to_oci.yaml

@@ -1,18 +1,51 @@
 ---
+apiVersion: v1
+kind: Secret
+metadata:
+  name: my-s3-credentials
+stringData:
+  AWS_ACCESS_KEY_ID: minioadmin
+  AWS_SECRET_ACCESS_KEY: minioadmin
+  AWS_BUCKET: default
+  AWS_REGION: us-east-1
+  AWS_ENDPOINT_URL: http://minio.minio.svc.cluster.local:9000
+---
+apiVersion: v1
+kind: Secret
+metadata:
+  name: my-oci-credentials
+type: kubernetes.io/dockerconfigjson
+stringData:
+  .dockerconfigjson: '{"auths": {"distribution-registry-test-service.default.svc.cluster.local:5001": {"auth": "base64(username:password)","email": "[email protected]"}}}'
+  ACCESS_TYPE: ["Push", "Pull"]
+  OCI_HOST: distribution-registry-test-service.default.svc.cluster.local:5001
+---
 apiVersion: batch/v1
 kind: Job
 metadata:
   name: my-async-upload-job
 spec:
   template:
     spec:
+      volumes:
+        - name: source-credentials
+          secret:
+            secretName: my-s3-credentials
+        - name: destination-credentials
+          secret:
+            secretName: my-oci-credentials
       restartPolicy: Never
       containers:
         - name: async-upload
           image: kubeflow/model-registry-async-job:local
+          volumeMounts:
+            - name: source-credentials
+              readOnly: true
+              mountPath: "/opt/creds/source"
+            - name: destination-credentials
+              readOnly: true
+              mountPath: "/opt/creds/destination"
           env:
-            - name: LOGLEVEL
-              value: "DEBUG"
             - name: HTTP_PROXY
               value: ""
             - name: HTTPS_PROXY
@@ -22,22 +55,18 @@ spec:
             # ---- Source ----------
             - name: MODEL_SYNC_SOURCE_TYPE
               value: "s3"
-            - name: MODEL_SYNC_SOURCE_AWS_BUCKET
-              value: "default"
             - name: MODEL_SYNC_SOURCE_AWS_KEY
               value: "my-model"
-            - name: MODEL_SYNC_SOURCE_AWS_ACCESS_KEY_ID
-              value: "minioadmin"
-            - name: MODEL_SYNC_SOURCE_AWS_SECRET_ACCESS_KEY
-              value: "minioadmin"
-            - name: MODEL_SYNC_SOURCE_AWS_ENDPOINT
-              value: "http://minio.minio.svc.cluster.local:9000"
+            - name: MODEL_SYNC_SOURCE_S3_CREDENTIALS_PATH
+              value: "/opt/creds/source"
 
             # ---- Destination -----
             - name: MODEL_SYNC_DESTINATION_TYPE
               value: "oci"
             - name: MODEL_SYNC_DESTINATION_OCI_URI
               value: "oci://distribution-registry-test-service.default.svc.cluster.local:5001/my-model:latest"
+            - name: MODEL_SYNC_DESTINATION_OCI_CREDENTIALS_PATH
+              value: "/opt/creds/destination"
 
             # ---- Model Params ----
             - name: MODEL_SYNC_MODEL_ID