Fix 500 error when no artifacts match the filters in hardware configuration table (#2095)

Signed-off-by: manaswinidas <[email protected]>

Author: manaswinidas

catalog/internal/db/models/performance_artifact_service.go

@@ -250,7 +250,13 @@ func (s *PerformanceArtifactService) generateRecommendations(artifacts []Catalog
 }
 
 // validateCustomProperties ensures at least one artifact contains each custom property
+// When there are no artifacts, validation passes (empty result is valid)
 func (s *PerformanceArtifactService) validateCustomProperties(artifacts []CatalogMetricsArtifact, rpsProperty, latencyProperty, hardwareCountProperty, hardwareTypeProperty string) error {
+	// If there are no artifacts, validation passes - empty result is valid
+	if len(artifacts) == 0 {
+		return nil
+	}
+
 	propertyExists := map[string]bool{
 		rpsProperty:           false,
 		latencyProperty:       false,

catalog/internal/db/models/performance_artifact_service_test.go

@@ -208,6 +208,10 @@ func TestPerformanceArtifactService_Recommendataions(t *testing.T) {
 func TestPropertyValidation(t *testing.T) {
 	service := NewPerformanceArtifactService(nil)
 
+	// Test case: empty artifacts should pass validation (not an error condition)
+	err := service.validateCustomProperties([]CatalogMetricsArtifact{}, "rps", "latency", "hw_count", "hw_type")
+	require.NoError(t, err, "Empty artifacts should not cause validation error")
+
 	// Test case: property exists in some artifacts
 	id1 := int32(1)
 	id2 := int32(2)
@@ -238,7 +242,7 @@ func TestPropertyValidation(t *testing.T) {
 	artifacts[1].SetID(id2)
 
 	// Should not error when property exists in at least one artifact
-	err := service.validateCustomProperties(artifacts, "custom_rps", "custom_latency", "custom_hw_count", "custom_hw_type")
+	err = service.validateCustomProperties(artifacts, "custom_rps", "custom_latency", "custom_hw_count", "custom_hw_type")
 	require.NoError(t, err)
 
 	// Test case: property doesn't exist in any artifact