feat: adapt the code to upstream

Signed-off-by: lucferbux <[email protected]>

Author: lucferbux

…i/bff/internal/redhat/docs/extensions.md clients/ui/bff/docs/extensions.mdclients/ui/bff/internal/redhat/docs/extensions.md renamed to clients/ui/bff/docs/extensions.md clients/ui/bff/internal/redhat/docs/extensions.md renamed to clients/ui/bff/docs/extensions.md

@@ -11,7 +11,7 @@ Some downstream builds (for example, the RHOAI dashboard) need to add behavior t
 ## Ownership boundaries
 
 - **Upstream-only artifacts** live under `internal/api`, `internal/repositories`, and the default handler tree. These packages must remain vendor-neutral and keep their existing contracts intact so downstream imports keep compiling.
-- **Downstream-only artifacts** live under `clients/ui/bff/internal/redhat` (and sibling vendor folders, if they are ever added). Any logic that assumes Red Hat credentials, namespaces, or controllers must stay here so other distributions do not pick it up accidentally.
+- **Downstream-only artifacts** live under `clients/ui/bff/internal/<override-folder>` (and sibling vendor folders, if they are ever added). Any logic that assumes Red Hat credentials, namespaces, or controllers must stay here so other distributions do not pick it up accidentally.
 - **Shared interfaces** (for example repository interfaces or the handler override registry itself) stay upstream. Only implementers that are specific to a vendor move downstream.
 
 Use this rule of thumb: if a change requires Red Hat-only RBAC, Kubernetes resources, or APIs that are invisible to open-source users, keep it downstream. Everything else should be proposed upstream.
@@ -54,7 +54,7 @@ func overrideModelRegistrySettingsList(app *api.App, _ func() httprouter.Handle)
         }
 
         // Use the client to fetch data from Kubernetes and build the response.
-        // Downstream repositories live in internal/redhat/repositories.
+        // Downstream repositories live in internal/<override-repository>/repositories.
         _ = client // placeholder for actual implementation
 
         resp := api.ModelRegistrySettingsListEnvelope{Data: nil}
@@ -69,27 +69,15 @@ Package registration is purely compile-time: add a blank import in `clients/ui/b
 
 ## Managing downstream overrides
 
-- **Structure** – Place handler factories below `clients/ui/bff/internal/redhat/handlers`, and keep any repository or helper implementations under `clients/ui/bff/internal/redhat/repositories`. This mirrors the upstream layout so the APIs remain familiar.
-- **Activation** – Overrides are active whenever their package is imported. Use a blank import (e.g., `_ "github.com/.../internal/redhat/handlers"`) in the main entry point to enable them. No configuration flags are needed.
+- **Structure** – Place handler factories below `clients/ui/bff/internal/<override-folder>/handlers`, and keep any repository or helper implementations under `clients/ui/bff/internal/<override-folder>/repositories`. This mirrors the upstream layout so the APIs remain familiar.
+- **Activation** – Overrides are active whenever their package is imported. Use a blank import (e.g., `_ "github.com/.../internal/<override-folder>/handlers"`) in the main entry point to enable them. No configuration flags are needed.
 - **Conditional delegation** – If an override needs to fall back to upstream logic under certain conditions, call `buildDefault()`. Otherwise, the downstream handler runs unconditionally.
 - **Shared clients** – Build Kubernetes or database clients via `app.KubernetesClientFactory()` or other upstream factories. Never duplicate client configuration downstream; add capabilities to the upstream factory instead when needed.
 - **Testing** – Keep unit and integration tests downstream next to the overrides. Use the upstream interfaces to mock dependencies the same way default handlers do.
 
 ## Change workflow
 
 1. **Add the handler ID upstream** – introduce a new `HandlerID` constant and wrap the router registration with `app.handlerWithOverride`. Document the ID in this file under *Current coverage*.
-2. **Introduce downstream logic** – implement handler factories (and any supporting repositories) under `clients/ui/bff/internal/redhat`. Register them in the package `init()` by calling `api.RegisterHandlerOverride`.
+2. **Introduce downstream logic** – implement handler factories (and any supporting repositories) under `clients/ui/bff/internal/<override-folder>`. Register them in the package `init()` by calling `api.RegisterHandlerOverride`.
 3. **Wire repositories** – if the downstream handler needs bespoke storage logic, implement a downstream repository that satisfies the upstream interface and expose it via `app.Repositories()` overrides.
 4. **Document and test** – update this guide when extending coverage, and add downstream tests to catch regressions before shipping.
-
-## Current coverage
-
-| Handler ID | Path |
-|------------|------|
-| `modelRegistrySettings:list` | `GET /api/v1/settings/model_registry` |
-| `modelRegistrySettings:create` | `POST /api/v1/settings/model_registry` |
-| `modelRegistrySettings:get` | `GET /api/v1/settings/model_registry/:model_registry_id` |
-| `modelRegistrySettings:update` | `PATCH /api/v1/settings/model_registry/:model_registry_id` |
-| `modelRegistrySettings:delete` | `DELETE /api/v1/settings/model_registry/:model_registry_id` |
-
-Additions follow the same pattern: declare a `HandlerID` constant, wrap the router registration with `app.handlerWithOverride`, and document the new ID here so downstream authors know it is available.

clients/ui/bff/internal/api/app.go

@@ -75,15 +75,6 @@ const (
 	CatalogSourcePreviewPath                 = ModelCatalogSettingsPathPrefix + "/source_preview"
 )
 
-const (
-	// TODO(upstream): Keep handler IDs unexported so the extension mechanism stays agnostic of downstream overrides.
-	handlerModelRegistrySettingsListID   HandlerID = "modelRegistrySettings:list"
-	handlerModelRegistrySettingsCreateID HandlerID = "modelRegistrySettings:create"
-	handlerModelRegistrySettingsGetID    HandlerID = "modelRegistrySettings:get"
-	handlerModelRegistrySettingsUpdateID HandlerID = "modelRegistrySettings:update"
-	handlerModelRegistrySettingsDeleteID HandlerID = "modelRegistrySettings:delete"
-)
-
 type App struct {
 	config                  config.EnvConfig
 	logger                  *slog.Logger
@@ -260,36 +251,11 @@ func (app *App) Routes() http.Handler {
 		// SettingsPath endpoints are used to manage the model registry settings and create new model registries
 		// We are still discussing the best way to create model registries in the community
 		// But in the meantime, those endpoints are STUBs endpoints used to unblock the frontend development
-		apiRouter.GET(
-			ModelRegistrySettingsListPath,
-			app.handlerWithOverride(handlerModelRegistrySettingsListID, func() httprouter.Handle {
-				return app.AttachNamespace(app.GetAllModelRegistriesSettingsHandler)
-			}),
-		)
-		apiRouter.POST(
-			ModelRegistrySettingsListPath,
-			app.handlerWithOverride(handlerModelRegistrySettingsCreateID, func() httprouter.Handle {
-				return app.AttachNamespace(app.CreateModelRegistrySettingsHandler)
-			}),
-		)
-		apiRouter.GET(
-			ModelRegistrySettingsPath,
-			app.handlerWithOverride(handlerModelRegistrySettingsGetID, func() httprouter.Handle {
-				return app.AttachNamespace(app.GetModelRegistrySettingsHandler)
-			}),
-		)
-		apiRouter.PATCH(
-			ModelRegistrySettingsPath,
-			app.handlerWithOverride(handlerModelRegistrySettingsUpdateID, func() httprouter.Handle {
-				return app.AttachNamespace(app.UpdateModelRegistrySettingsHandler)
-			}),
-		)
-		apiRouter.DELETE(
-			ModelRegistrySettingsPath,
-			app.handlerWithOverride(handlerModelRegistrySettingsDeleteID, func() httprouter.Handle {
-				return app.AttachNamespace(app.DeleteModelRegistrySettingsHandler)
-			}),
-		)
+		apiRouter.GET(ModelRegistrySettingsListPath, app.AttachNamespace(app.GetAllModelRegistriesSettingsHandler))
+		apiRouter.POST(ModelRegistrySettingsListPath, app.AttachNamespace(app.CreateModelRegistrySettingsHandler))
+		apiRouter.GET(ModelRegistrySettingsPath, app.AttachNamespace(app.GetModelRegistrySettingsHandler))
+		apiRouter.PATCH(ModelRegistrySettingsPath, app.AttachNamespace(app.UpdateModelRegistrySettingsHandler))
+		apiRouter.DELETE(ModelRegistrySettingsPath, app.AttachNamespace(app.DeleteModelRegistrySettingsHandler))
 
 		//SettingsPath: Certificate endpoints
 		apiRouter.GET(CertificatesPath, app.AttachNamespace(app.GetCertificatesHandler))

clients/ui/bff/internal/api/extensions.go

@@ -30,6 +30,7 @@ func RegisterHandlerOverride(id HandlerID, factory HandlerFactory) {
 	handlerOverrides[id] = factory
 }
 
+//nolint:unused // Used by downstream implementations
 func getHandlerOverride(id HandlerID) HandlerFactory {
 	handlerOverrideMu.RLock()
 	defer handlerOverrideMu.RUnlock()
@@ -38,6 +39,8 @@ func getHandlerOverride(id HandlerID) HandlerFactory {
 
 // handlerWithOverride returns the handler registered for the given id or builds the default one.
 // TODO(upstream): This glue stays upstream so the router keeps working even when no downstream overrides exist.
+//
+//nolint:unused // Used by downstream implementations
 func (app *App) handlerWithOverride(id HandlerID, buildDefault func() httprouter.Handle) httprouter.Handle {
 	if factory := getHandlerOverride(id); factory != nil {
 		app.logHandlerOverride(id)
@@ -46,6 +49,7 @@ func (app *App) handlerWithOverride(id HandlerID, buildDefault func() httprouter
 	return buildDefault()
 }
 
+//nolint:unused // Used by downstream implementations
 func (app *App) logHandlerOverride(id HandlerID) {
 	if app == nil || app.logger == nil {
 		return