adds an option to specify whether informers should fail on error, which defaults to false to maintain existing compatibility

Author: emsixteeen

pkg/controller/mpi_job_controller.go

@@ -348,7 +348,7 @@ func NewMPIJobControllerWithClock(
 
 	// Set up error handlers for informers
 	klog.Info("Setting up informer error handlers")
-	informers := map[string]cache.SharedIndexInformer{
+	informers := map[string]cache.SharedInformer{
 		"configMapInformer":     configMapInformer.Informer(),
 		"secretInformer":        secretInformer.Informer(),
 		"serviceInformer":       serviceInformer.Informer(),
@@ -364,12 +364,13 @@ func NewMPIJobControllerWithClock(
 			cache.DefaultWatchErrorHandler(r, err)
 
 			if errors.IsUnauthorized(err) || errors.IsForbidden(err) {
-				klog.Fatalf("Unable to sync cache for informer %s: %s. Exiting.", name, err)
+				klog.Fatalf("Unable to sync cache for informer %s: %s. Requesting controller to exit.", name, err)
 			}
 		})
 
 		if err != nil {
-			klog.Fatalf("Unable to set error handler for informer %s: %s. Exiting.", name, err)
+			// return NewMPIJobControllerWithClock(...) (nil, error)
+			return nil, fmt.Errorf("unable to set error handler for informer %s: %s", name, err)
 		}
 	}