Skip to content

Commit c7b032c

Browse files
committed
no overwrite when run launcher as worker
Signed-off-by: kuizhiqing <[email protected]>
1 parent f92b9c7 commit c7b032c

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

pkg/controller/mpi_job_controller.go

+7-6
Original file line numberDiff line numberDiff line change
@@ -1534,12 +1534,13 @@ func (c *MPIJobController) newLauncherPodTemplate(mpiJob *kubeflow.MPIJob) corev
15341534
case kubeflow.MPIImplementationMPICH:
15351535
container.Env = append(container.Env, mpichEnvVars...)
15361536
}
1537-
1538-
container.Env = append(container.Env,
1539-
// We overwrite these environment variables so that users will not
1540-
// be mistakenly using GPU resources for launcher due to potential
1541-
// issues with scheduler/container technologies.
1542-
nvidiaDisableEnvVars...)
1537+
if !ptr.Deref(mpiJob.Spec.RunLauncherAsWorker, false) {
1538+
container.Env = append(container.Env,
1539+
// We overwrite these environment variables so that users will not
1540+
// be mistakenly using GPU resources for launcher due to potential
1541+
// issues with scheduler/container technologies.
1542+
nvidiaDisableEnvVars...)
1543+
}
15431544
c.setupSSHOnPod(&podTemplate.Spec, mpiJob)
15441545

15451546
// Submit a warning event if the user specifies restart policy for

0 commit comments

Comments
 (0)