Skip to content

Commit 070cbb8

Browse files
chore: update main readme + disallow semantic scopes (#772)
* chore: update readme Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> * chore: disallow commit message scopes Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> --------- Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
1 parent 5c7abde commit 070cbb8

File tree

3 files changed

+11
-31
lines changed

3 files changed

+11
-31
lines changed

.github/workflows/semantic-prs.yaml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
name: Validate Title
1818
runs-on: ubuntu-latest
1919
steps:
20-
- uses: amannn/action-semantic-pull-request@v5.5.3
20+
- uses: amannn/action-semantic-pull-request@48f256284bd46cdaab1048c3721360e808335d50 # v6.1.1
2121
env:
2222
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2323
with:
@@ -32,9 +32,5 @@ jobs:
3232
docs
3333
chore
3434
35-
scopes: |
36-
nb
37-
pvc
38-
tb
39-
ws
40-
requireScope: false
35+
# disallow all commit scopes
36+
disallowScopes: ".*"

CONTRIBUTING.md

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -35,20 +35,11 @@ A semantic commit message must start with one of the following __prefixes__:
3535

3636
To indicate a breaking change, add `!` after the prefix, e.g. `feat!: my commit message`.
3737

38-
### Scopes
39-
40-
You may optionally include a __scope__ after the prefix, for example:
41-
42-
- `nb` (changes to notebooks - web-app, controller, images)
43-
- `pvc` (changes to volumes - web-app, controller)
44-
- `tb` (changes to tensorboards - web-app, controller)
45-
- `ws` (changes to workspaces - frontend, backend, controller, images)
46-
4738
### Examples
4839

4940
Here are some examples of semantic commit messages:
5041

51-
- `fix(nb): something that was broken`
52-
- `feat(ws): a new feature`
42+
- `fix: something that was broken`
43+
- `feat: a new feature`
5344
- `improve: a general improvement`
5445
- `chore: update readme`

README.md

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
# Kubeflow Notebooks
22
[![OpenSSF Best Practices](https://www.bestpractices.dev/projects/9942/badge)](https://www.bestpractices.dev/projects/9942)
33

4-
[Kubeflow Notebooks](https://www.kubeflow.org/docs/components/notebooks/overview/) lets you run web-based development environments on your Kubernetes cluster by running them inside Pods.
4+
[Kubeflow Notebooks](https://www.kubeflow.org/docs/components/notebooks/overview/) runs __interactive development environments__ for AI, ML, and Data workloads on __Kubernetes__.
55

6-
> ⚠️ __Note__ ⚠️
6+
> [!NOTE]
77
>
8-
> We are currently moving the _Kubeflow Notebooks 1.0_ codebase from [`kubeflow/kubeflow`](https://github.com/kubeflow/kubeflow) to this repository ([`kubeflow/notebooks`](https://github.com/kubeflow/notebooks)).
9-
> Please see [`kubeflow/kubeflow#7549`](https://github.com/kubeflow/kubeflow/issues/7549) for more information.
8+
> This repository contains two major versions of Kubeflow Notebooks:
109
>
11-
> We are currently developing _Kubeflow Notebooks 2.0_ in this repository under the [`notebooks-v2`](https://github.com/kubeflow/notebooks/tree/notebooks-v2) branch.
12-
> Please see [`kubeflow/notebooks#85`](https://github.com/kubeflow/notebooks/issues/85) for more information.
10+
> - The [`notebooks-v1`](https://github.com/kubeflow/notebooks/tree/notebooks-v1) branch contains the codebase for _Kubeflow Notebooks v1_.
11+
> - The [`notebooks-v2`](https://github.com/kubeflow/notebooks/tree/notebooks-v2) branch contains the codebase for _Kubeflow Notebooks v2_.
1312
1413
## What is Kubeflow Notebooks?
1514

@@ -20,12 +19,6 @@ Key features of Kubeflow Notebooks:
2019
- Admins can provide [standard notebook images](https://www.kubeflow.org/docs/components/notebooks/container-images/) for their organization with required packages pre-installed.
2120
- Access control is managed by [Kubeflow’s RBAC](https://www.kubeflow.org/docs/components/central-dash/profiles/), enabling easier notebook sharing across the organization.
2221

23-
## Installation
24-
25-
Kubeflow Notebooks is designed to be deployed as part of a [Kubeflow Platform](https://www.kubeflow.org/docs/started/introduction/#what-is-kubeflow-platform) (not as a standalone component).
26-
27-
Please refer to the [Installing Kubeflow](https://www.kubeflow.org/docs/started/installing-kubeflow/) page for more information.
28-
2922
## Documentation
3023

3124
The official documentation for Kubeflow Notebooks can be found [here](https://www.kubeflow.org/docs/components/notebooks/).
@@ -41,4 +34,4 @@ Connect with _other users_ and the [Notebooks Working Group](https://github.com/
4134

4235
## Contributing
4336

44-
Please see the [`CONTRIBUTING.md`](CONTRIBUTING.md) file for more information.
37+
Please see the [`CONTRIBUTING.md`](https://github.com/kubeflow/notebooks/blob/main/CONTRIBUTING.md) file for more information.

0 commit comments

Comments
 (0)