Skip to content

Commit 13284fc

Browse files
committed
Add descriptions to Secrets in Workspace creation wizard
Signed-off-by: Charles Thao <[email protected]>
1 parent 4b7b453 commit 13284fc

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

workspaces/frontend/src/app/pages/Workspaces/Creation/properties/WorkspaceCreationPropertiesSecrets.tsx

+8-4
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,9 @@ interface WorkspaceCreationPropertiesSecretsProps {
2525
setSecrets: React.Dispatch<React.SetStateAction<WorkspaceSecret[]>>;
2626
}
2727

28-
export const WorkspaceCreationPropertiesSecrets: React.FC<WorkspaceCreationPropertiesSecretsProps> = ({
29-
secrets,
30-
setSecrets,
31-
}) => {
28+
export const WorkspaceCreationPropertiesSecrets: React.FC<
29+
WorkspaceCreationPropertiesSecretsProps
30+
> = ({ secrets, setSecrets }) => {
3231
const [isModalOpen, setIsModalOpen] = useState(false);
3332
const [isDeleteModalOpen, setIsDeleteModalOpen] = useState(false);
3433
const [formData, setFormData] = useState<WorkspaceSecret>({
@@ -157,6 +156,11 @@ export const WorkspaceCreationPropertiesSecrets: React.FC<WorkspaceCreationPrope
157156
<ModalHeader
158157
title={editIndex === null ? 'Create Secret' : 'Edit Secret'}
159158
labelId="secret-modal-title"
159+
description={
160+
editIndex === null
161+
? 'Add a secret to securely use API keys, tokens, or other credentials in your workspace.'
162+
: ''
163+
}
160164
/>
161165
<ModalBody id="secret-modal-box-body">
162166
<Form onSubmit={handleAddOrEditSubmit}>

workspaces/frontend/src/app/pages/Workspaces/Creation/properties/WorkspaceCreationPropertiesSelection.tsx

+9-8
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {
1414
import { WorkspaceCreationImageDetails } from '~/app/pages/Workspaces/Creation/image/WorkspaceCreationImageDetails';
1515
import { WorkspaceCreationPropertiesVolumes } from '~/app/pages/Workspaces/Creation/properties/WorkspaceCreationPropertiesVolumes';
1616
import { WorkspaceImage, WorkspaceVolumes, WorkspaceVolume, WorkspaceSecret } from '~/shared/types';
17-
import WorkspaceCreationPropertiesSecrets from './WorkspaceCreationPropertiesSecrets';
17+
import { WorkspaceCreationPropertiesSecrets } from './WorkspaceCreationPropertiesSecrets';
1818

1919
interface WorkspaceCreationPropertiesSelectionProps {
2020
selectedImage: WorkspaceImage | undefined;
@@ -136,14 +136,15 @@ const WorkspaceCreationPropertiesSelection: React.FunctionComponent<
136136
</FormGroup>
137137
)}
138138
</ExpandableSection>
139-
{!isSecretsExpanded && (
140-
<div style={{ paddingLeft: '36px' }}>
141-
<div className="pf-u-font-size-sm">
142-
<strong>{secrets.length} added</strong>
143-
</div>
144-
</div>
145-
)}
146139
</div>
140+
{!isSecretsExpanded && (
141+
<div style={{ paddingLeft: '36px', marginTop: '-10px' }}>
142+
<div>Secrets enable your project to securely access and manage credentials.</div>
143+
<div className="pf-u-font-size-sm">
144+
<strong>{secrets.length} added</strong>
145+
</div>
146+
</div>
147+
)}
147148
</Form>
148149
</div>
149150
</SplitItem>

0 commit comments

Comments
 (0)