Externalize consts

Signed-off-by: Matheus Cruz <[email protected]>

Author: mcruzdev

workspaces/controller/internal/controller/workspace_controller.go

@@ -78,6 +78,10 @@ const (
 	stateMsgRunning                        = "Workspace is running"
 	stateMsgTerminating                    = "Workspace is terminating"
 	stateMsgUnknown                        = "Workspace is in an unknown state"
+
+	IstioHost     = "ISTIO_HOST"
+	IstioGateway  = "ISTIO_GATEWAY"
+	ClusterDomain = "CLUSTER_DOMAIN"
 )
 
 // WorkspaceReconciler reconciles a Workspace object
@@ -1037,13 +1041,13 @@ func GenerateIstioVirtualService(workspace *kubefloworgv1beta1.Workspace, worksp
 	virtualService.SetNamespace(workspace.Namespace)
 
 	// .spec.gateways
-	istioGateway := getEnvOrDefault("ISTIO_GATEWAY", "kubeflow/kubeflow-gateway")
+	istioGateway := getEnvOrDefault(IstioGateway, "kubeflow/kubeflow-gateway")
 	if err := unstructured.SetNestedStringSlice(virtualService.Object, []string{istioGateway},
 		"spec", "gateways"); err != nil {
 		return nil, fmt.Errorf("set .spec.gateways error: %v", err)
 	}
 
-	istioHost := getEnvOrDefault("ISTIO_HOST", "*")
+	istioHost := getEnvOrDefault(IstioHost, "*")
 	if err := unstructured.SetNestedStringSlice(virtualService.Object, []string{istioHost},
 		"spec", "gateways"); err != nil {
 		return nil, fmt.Errorf("set .spec.hosts error: %v", err)
@@ -1057,7 +1061,7 @@ func GenerateIstioVirtualService(workspace *kubefloworgv1beta1.Workspace, worksp
 
 	var httpRoutes []interface{}
 
-	host := fmt.Sprintf("%s.%s.svc.%s", serviceName, workspace.Namespace, getEnvOrDefault("CLUSTER_DOMAIN", "cluster.local"))
+	host := fmt.Sprintf("%s.%s.svc.%s", serviceName, workspace.Namespace, getEnvOrDefault(ClusterDomain, "cluster.local"))
 
 	// generate container ports
 	// TODO: It can be better