Skip to content

Commit ff713aa

Browse files
authored
refactor(ws): Enhance "Create Workspace" Title Spacing (#266)
Signed-off-by: Jenny <[email protected]>
1 parent e1e067c commit ff713aa

File tree

1 file changed

+77
-63
lines changed

1 file changed

+77
-63
lines changed

workspaces/frontend/src/app/pages/Workspaces/Creation/WorkspaceCreation.tsx

+77-63
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ import {
88
PageSection,
99
ProgressStep,
1010
ProgressStepper,
11+
Stack,
12+
StackItem,
1113
} from '@patternfly/react-core';
1214
import { useCallback, useState } from 'react';
1315
import { useNavigate } from 'react-router-dom';
@@ -68,69 +70,81 @@ const WorkspaceCreation: React.FunctionComponent = () => {
6870
<>
6971
<PageGroup stickyOnBreakpoint={{ default: 'top' }}>
7072
<PageSection isFilled={false}>
71-
<Content>
72-
<h1>Create workspace</h1>
73-
</Content>
74-
<ProgressStepper aria-label="Workspace creation stepper">
75-
<ProgressStep
76-
variant={getStepVariant(WorkspaceCreationSteps.KindSelection)}
77-
id="kind-selection-step"
78-
icon={
79-
getStepVariant(WorkspaceCreationSteps.KindSelection) === 'success' ? (
80-
<CheckIcon />
81-
) : (
82-
1
83-
)
84-
}
85-
titleId="kind-selection-step-title"
86-
aria-label="Kind selection step"
87-
>
88-
Workspace Kind
89-
</ProgressStep>
90-
<ProgressStep
91-
variant={getStepVariant(WorkspaceCreationSteps.ImageSelection)}
92-
isCurrent
93-
id="image-selection-step"
94-
icon={
95-
getStepVariant(WorkspaceCreationSteps.ImageSelection) === 'success' ? (
96-
<CheckIcon />
97-
) : (
98-
2
99-
)
100-
}
101-
titleId="image-selection-step-title"
102-
aria-label="Image selection step"
103-
>
104-
Image
105-
</ProgressStep>
106-
<ProgressStep
107-
variant={getStepVariant(WorkspaceCreationSteps.PodConfigSelection)}
108-
isCurrent
109-
id="pod-config-selection-step"
110-
icon={
111-
getStepVariant(WorkspaceCreationSteps.PodConfigSelection) === 'success' ? (
112-
<CheckIcon />
113-
) : (
114-
3
115-
)
116-
}
117-
titleId="pod-config-selection-step-title"
118-
aria-label="Pod config selection step"
119-
>
120-
Pod Config
121-
</ProgressStep>
122-
<ProgressStep
123-
variant={getStepVariant(WorkspaceCreationSteps.Properties)}
124-
id="properties-step"
125-
icon={
126-
getStepVariant(WorkspaceCreationSteps.Properties) === 'success' ? <CheckIcon /> : 4
127-
}
128-
titleId="properties-step-title"
129-
aria-label="Properties step"
130-
>
131-
Properties
132-
</ProgressStep>
133-
</ProgressStepper>
73+
<Stack hasGutter>
74+
<StackItem>
75+
<Flex>
76+
<Content>
77+
<h1>Create workspace</h1>
78+
</Content>
79+
</Flex>
80+
</StackItem>
81+
<StackItem>
82+
<ProgressStepper aria-label="Workspace creation stepper">
83+
<ProgressStep
84+
variant={getStepVariant(WorkspaceCreationSteps.KindSelection)}
85+
id="kind-selection-step"
86+
icon={
87+
getStepVariant(WorkspaceCreationSteps.KindSelection) === 'success' ? (
88+
<CheckIcon />
89+
) : (
90+
1
91+
)
92+
}
93+
titleId="kind-selection-step-title"
94+
aria-label="Kind selection step"
95+
>
96+
Workspace Kind
97+
</ProgressStep>
98+
<ProgressStep
99+
variant={getStepVariant(WorkspaceCreationSteps.ImageSelection)}
100+
isCurrent
101+
id="image-selection-step"
102+
icon={
103+
getStepVariant(WorkspaceCreationSteps.ImageSelection) === 'success' ? (
104+
<CheckIcon />
105+
) : (
106+
2
107+
)
108+
}
109+
titleId="image-selection-step-title"
110+
aria-label="Image selection step"
111+
>
112+
Image
113+
</ProgressStep>
114+
<ProgressStep
115+
variant={getStepVariant(WorkspaceCreationSteps.PodConfigSelection)}
116+
isCurrent
117+
id="pod-config-selection-step"
118+
icon={
119+
getStepVariant(WorkspaceCreationSteps.PodConfigSelection) === 'success' ? (
120+
<CheckIcon />
121+
) : (
122+
3
123+
)
124+
}
125+
titleId="pod-config-selection-step-title"
126+
aria-label="Pod config selection step"
127+
>
128+
Pod Config
129+
</ProgressStep>
130+
<ProgressStep
131+
variant={getStepVariant(WorkspaceCreationSteps.Properties)}
132+
id="properties-step"
133+
icon={
134+
getStepVariant(WorkspaceCreationSteps.Properties) === 'success' ? (
135+
<CheckIcon />
136+
) : (
137+
4
138+
)
139+
}
140+
titleId="properties-step-title"
141+
aria-label="Properties step"
142+
>
143+
Properties
144+
</ProgressStep>
145+
</ProgressStepper>
146+
</StackItem>
147+
</Stack>
134148
</PageSection>
135149
</PageGroup>
136150
<PageSection isFilled>

0 commit comments

Comments
 (0)