Skip to content

fix: add lease RBAC to notebook controller role (for leader election) #6942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sergeyshevch
Copy link

@google-cla
Copy link

google-cla bot commented Feb 7, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval by writing /assign @thesuperzapper in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

Can you join the next Notebooks Working Group or Manifest working Group meeting? We are always looking for help. And this is where you can present your PR. Just propose it on the agenda and join.

https://www.kubeflow.org/docs/about/community/#kubeflow-community-calendars has the calendar and meeting notes.

You can also reach us on slack in the channel wg-notebooks and wg-manifests

@thesuperzapper thesuperzapper changed the title fix: Fix Notebook controller leader-election role fix: add lease RBAC to notebook controller role May 12, 2024
@thesuperzapper thesuperzapper changed the title fix: add lease RBAC to notebook controller role fix: add lease RBAC to notebook controller role (for leader election) May 12, 2024
@thesuperzapper thesuperzapper added this to the v1.9.1 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notebook Controller Leader Election
3 participants