Culling only counting latest timestamp on api/kernels without considering api/terminals

[wjhhuizi]

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

The Culling controller does not taking timestamps from api/terminals into consideration.

What did you expect to happen:
User shall be able to config Culling controller to consider terminals workload by adding options to the notebook-controller-config, for example:

CULL_OPTION: KERNEL | TERMINAL | BOTH | NETWORK

KERNEL corresponds to: `api/kernels`
TERMINAL corresponds to: `api/terminals`
BOTH took above 2 into consideration
NETWORK corresponds to: `api/status`

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Please explain the current implementation which only aggregating latest_activity timestamp from api/kernels is purposefully or a bug.

Thank you!

Environment:

• Kubeflow version: (version number can be found at the bottom left corner of the Kubeflow dashboard): 1.7.0
• kfctl version: (use kfctl version): N/A
• Kubernetes platform: (e.g. minikube) AKS
• Kubernetes version: (use kubectl version): 1.25
• OS (e.g. from /etc/os-release): Ubuntu

[wadhah101]

Thanks for raising this issue, I am also affected by it.

here's my +1

[juliusvonkohout]

Please help to integrate it into #93

[wjhhuizi]

Updating proposal to

CULL_OPTION: KERNEL | TERMINAL | BOTH | NETWORK | NETWORK+
--------
# KERNEL corresponds to: `api/kernels`
# TERMINAL corresponds to: `api/terminals`
# BOTH took above 2 into consideration
# NETWORK corresponds to: `api/status`
# NETWORK+ took consideration on both api/status and KERNEL idleness

[em-le-ts]

+1

[andreyvelich]

/transfer notebooks

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed if no further activity occurs.
Thank you for your contributions.

Members may comment /lifecycle frozen to prevent this issue from being marked as stale.