Skip to content

feat(ws): Workspace list: Selectable rows #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: notebooks-v2
Choose a base branch
from

Conversation

paulovmr
Copy link

@paulovmr paulovmr commented Feb 5, 2025

Fixes #194

No workspaces selected:
Screenshot from 2025-03-06 13-05-48

One workspace selected:
Screenshot from 2025-03-06 13-05-54

Multiple workspaces selected:
Screenshot from 2025-03-06 13-05-59

@ederign
Copy link
Member

ederign commented Feb 27, 2025

/assign @ederign

@ederign
Copy link
Member

ederign commented Feb 27, 2025

@paulovmr can you please ping me when this is ready to review?

@paulovmr paulovmr force-pushed the notebooks-v2-aggregated-drawer branch from 5494b44 to c332481 Compare March 6, 2025 15:26
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ederign. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented May 1, 2025

/retitle feat(ws): Workspace list: Selectable rows

@google-oss-prow google-oss-prow bot changed the title feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Selectable rows feat(ws): Workspace list: Selectable rows May 1, 2025
@paulovmr paulovmr force-pushed the notebooks-v2-aggregated-drawer branch from 8004ea2 to 112ccef Compare May 14, 2025 15:14
@paulovmr
Copy link
Author

/ok-to-test

@paulovmr paulovmr force-pushed the notebooks-v2-aggregated-drawer branch from 112ccef to 9262517 Compare May 14, 2025 15:17
@paulovmr
Copy link
Author

PR rebased.
Hi @jenny-s51 , if you could please review this one. Thanks!

@paulovmr paulovmr force-pushed the notebooks-v2-aggregated-drawer branch 2 times, most recently from 17df508 to c0aecc6 Compare June 5, 2025 14:32
@paulovmr paulovmr force-pushed the notebooks-v2-aggregated-drawer branch from c0aecc6 to 98c71ed Compare June 5, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants