Skip to content

Commit 135715d

Browse files
jingzhang36Bobgy
authored andcommitted
Reduce ttl of persisted final workflow to 1 day (#4005)
* reduce ttl of pesisted final workflow to 1 day * add comment * enable pagination when expanding experiment in both the home page and the archive page * Revert "enable pagination when expanding experiment in both the home page and the archive page" This reverts commit 5b67273. * Address comments
1 parent 9c4e864 commit 135715d

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

backend/Dockerfile.persistenceagent

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ COPY --from=builder /go/src/github.com/kubeflow/pipelines/third_party/license.tx
1717

1818
ENV NAMESPACE ""
1919

20-
# Set Workflow TTL to 7 days
21-
ENV TTL_SECONDS_AFTER_WORKFLOW_FINISH 604800
20+
# Set Workflow TTL to 1 day. The way to use a different value for a particular Kubeflow Pipelines deployment is demonstrated in manifests/kustomize/base/pipeline/ml-pipeline-persistenceagent-deployment.yaml
21+
ENV TTL_SECONDS_AFTER_WORKFLOW_FINISH 86400
2222

2323
CMD persistence_agent --logtostderr=true --namespace=${NAMESPACE} --ttlSecondsAfterWorkflowFinish=${TTL_SECONDS_AFTER_WORKFLOW_FINISH}

manifests/gcp_marketplace/chart/kubeflow-pipelines/templates/pipeline.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -514,6 +514,8 @@ spec:
514514
- env:
515515
- name: NAMESPACE
516516
value: {{ .Release.Namespace }}
517+
- name: TTL_SECONDS_AFTER_WORKFLOW_FINISH
518+
value: "86400"
517519
image: {{ .Values.images.persistenceagent }}
518520
imagePullPolicy: IfNotPresent
519521
name: ml-pipeline-persistenceagent

manifests/kustomize/base/pipeline/ml-pipeline-persistenceagent-deployment.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ spec:
1919
valueFrom:
2020
fieldRef:
2121
fieldPath: metadata.namespace
22+
- name: TTL_SECONDS_AFTER_WORKFLOW_FINISH
23+
value: "86400"
2224
image: gcr.io/ml-pipeline/persistenceagent:dummy
2325
imagePullPolicy: IfNotPresent
2426
name: ml-pipeline-persistenceagent

0 commit comments

Comments
 (0)