controller: treat missing semaphore as unlimited

sduvvuri1603 · sduvvuri1603 · commit 542637deff30 · 2026-01-28T06:39:26.000-05:00
Signed-off-by: sduvvuri1603 &lt;sduvvuri@redhat.com&gt;
diff --git a/backend/src/crd/controller/scheduledworkflow/controller.go b/backend/src/crd/controller/scheduledworkflow/controller.go
@@ -623,7 +623,8 @@ func (c *Controller) extractMaxActiveRunsFromWorkflow(ctx context.Context, workf
 		workflow.ExecutionObjectMeta().Annotations[commonutil.AnnotationKeyPipelineVersionID] = id
 	}
 	if workflow.Spec.Synchronization == nil {
-		return 0, fmt.Errorf("workflow missing synchronization block; cannot derive max_active_runs")
+		// No concurrency limit configured; nothing to enforce.
+		return 0, nil
 	}
 
 	var pipelineVersionID string
@@ -642,7 +643,8 @@ func (c *Controller) extractMaxActiveRunsFromWorkflow(ctx context.Context, workf
 	}
 
 	if pipelineVersionID == "" {
-		return 0, fmt.Errorf("no pipeline version ID found in workflow synchronization semaphores")
+		// The workflow does not reference the parallelism semaphore; no limit applies.
+		return 0, nil
 	}
 
 	if c.pipelineClient == nil || pipelineID == "" {

Original file line number	Diff line number	Diff line change
`@@ -623,7 +623,8 @@ func (c *Controller) extractMaxActiveRunsFromWorkflow(ctx context.Context, workf`
`623`	`623`	`workflow.ExecutionObjectMeta().Annotations[commonutil.AnnotationKeyPipelineVersionID] = id`
`624`	`624`	`}`
`625`	`625`	`if workflow.Spec.Synchronization == nil {`
`626`		`- return 0, fmt.Errorf("workflow missing synchronization block; cannot derive max_active_runs")`
	`626`	`+ // No concurrency limit configured; nothing to enforce.`
	`627`	`+ return 0, nil`
`627`	`628`	`}`
`628`	`629`
`629`	`630`	`var pipelineVersionID string`
`@@ -642,7 +643,8 @@ func (c *Controller) extractMaxActiveRunsFromWorkflow(ctx context.Context, workf`
`642`	`643`	`}`
`643`	`644`
`644`	`645`	`if pipelineVersionID == "" {`
`645`		`- return 0, fmt.Errorf("no pipeline version ID found in workflow synchronization semaphores")`
	`646`	`+ // The workflow does not reference the parallelism semaphore; no limit applies.`
	`647`	`+ return 0, nil`
`646`	`648`	`}`
`647`	`649`
`648`	`650`	`if c.pipelineClient == nil \|\| pipelineID == "" {`