Skip to content

Commit 791a228

Browse files
committed
grpc tls fix
Signed-off-by: alyssacgoins <[email protected]>
1 parent 19f64ec commit 791a228

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

backend/src/apiserver/main.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ func initCerts() (*tls.Config, error) {
9999
return nil, err
100100
}
101101
tlsCfg := &tls.Config{
102+
ServerName: common.GetMLPipelineServiceName() + "." + common.GetPodNamespace() + ".svc.cluster.local",
102103
Certificates: []tls.Certificate{serverCert},
103104
}
104105
glog.Info("TLS cert key/pair loaded.")

backend/src/v2/config/env.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ func getDefaultMinioSessionInfo() (objectstore.SessionInfo, error) {
194194

195195
func GetMLPipelineServerConfig() *ServerConfig {
196196
return &ServerConfig{
197-
Address: common.GetMLPipelineServiceName() + "." + common.GetPodNamespace(),
197+
Address: common.GetMLPipelineServiceName() + "." + common.GetPodNamespace() + ".svc.cluster.local",
198198
Port: mlPipelineGrpcServicePort,
199199
}
200200
}

manifests/kustomize/env/cert-manager/base-tls-certs/kfp-api-cert.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,14 @@ spec:
88
dnsNames:
99
- ml-pipeline
1010
- ml-pipeline.kubeflow
11+
- ml-pipeline.kubeflow.svc.cluster.local
1112
- ml-pipeline-scheduledworkflow
1213
- metadata-envoy
1314
- metadata-envoy-service
1415
- metadata-grpc-service
1516
- metadata-grpc-service.kubeflow
1617
- metadata-grpc-service.$(kfp-namespace).svc.cluster.local
18+
# localhost included here because cert is used in KFP pod-to-pod TLS-enabled testing against localhost base URL.
1719
- localhost
1820
ipAddresses:
1921
# Necessary for running TLS-enabled cluster locally.

0 commit comments

Comments
 (0)