test: cover max_active_runs version requirement

Signed-off-by: sduvvuri1603 <[email protected]>

Author: sduvvuri1603

backend/test/compiler/argo_ginkgo_test.go

@@ -118,6 +118,7 @@ var _ = Describe("Verify Spec Compilation to Workflow >", Label(POSITIVE, Workfl
 				It(fmt.Sprintf("When I compile %s pipeline spec, then the compiled yaml should be %s", pipelineSpecFileName, compiledWorkflowFileName), func() {
 					testutil.CheckIfSkipping(pipelineSpecFileName)
 					pipelineSpecs, platformSpec := workflowutils.LoadPipelineSpecsFromIR(pipelineSpecFilePath, param.compilerOptions.CacheDisabled, nil)
+					param.compilerOptions.PipelineVersionID = testutil.EnsurePipelineVersionID()
 					compiledWorkflow := workflowutils.GetCompiledArgoWorkflow(pipelineSpecs, platformSpec, &param.compilerOptions)
 					if *createMissingGoldenFiles || *updateGoldenFiles {
 						var configuredWorkflow *v1alpha1.Workflow
@@ -141,3 +142,13 @@ var _ = Describe("Verify Spec Compilation to Workflow >", Label(POSITIVE, Workfl
 		})
 	}
 })
+
+var _ = Describe("Compiler validation >", Label(NEGATIVE, WorkflowCompiler), func() {
+	It("fails when max_active_runs is set without a pipeline version ID", func() {
+		pipelineSpecFilePath := filepath.Join(pipelineFilesRootDir, pipelineDirectory, "essential", "pipeline_with_max_active_runs.yaml")
+		pipelineSpecs, platformSpec := workflowutils.LoadPipelineSpecsFromIR(pipelineSpecFilePath, false, nil)
+		_, err := argocompiler.Compile(pipelineSpecs, platformSpec, &argocompiler.Options{})
+		Expect(err).To(HaveOccurred())
+		Expect(err.Error()).To(ContainSubstring("maxActiveRuns requires a pipeline version ID to enforce concurrency limits"))
+	})
+})

backend/test/testutil/test_utils.go

@@ -48,6 +48,11 @@ func ParsePointersToString(s *string) string {
 	}
 }
 
+// EnsurePipelineVersionID generates a deterministic placeholder pipeline version ID for tests.
+func EnsurePipelineVersionID() string {
+	return "test-version-id"
+}
+
 // GetRandomString - Get a random string of length x
 func GetRandomString(length int) string {
 	charset := "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"

test_data/compiled-workflows/pipeline_with_max_active_runs.yaml

@@ -33,6 +33,11 @@ spec:
     labels:
       pipelines.kubeflow.org/v2_component: "true"
   serviceAccountName: pipeline-runner
+  synchronization:
+    semaphores:
+    - configMapKeyRef:
+        key: test-version-id
+        name: kfp-argo-workflow-semaphores
   templates:
   - container:
       args: