refactor: remove unused SetSortByFieldPrefix and SetKeyFieldPrefix methods from Options

refactor(dialect): enhance identifier quoting to escape embedded quotes for MySQL, PostgreSQL, and SQLite

refactor: rename qualifyIdentifier to QualifyIdentifier and update references

feat: remove PostgreSQL-MinIO test configuration

chore: update Go version to 1.24 in integration test workflows

refactor: streamline PostgreSQL integration by updating kustomization files and removing unused network policies

refactor: update PostgreSQL network policy references and remove obsolete file

Signed-off-by: kaikaila <[email protected]>

Author: kaikaila

.github/resources/manifests/multiuser/postgresql-minio/apiserver-env.yaml

@@ -142,38 +142,35 @@ if [ "${MULTI_USER}" == "true" ]; then
 fi
 
 # Manifests will be deployed according to the flag provided
+# Priority 1: Multi-user false + standalone (not kubernetes-native)
 if [ "${MULTI_USER}" == "false" ] && [ "${PIPELINES_STORE}" != "kubernetes" ]; then
   TEST_MANIFESTS="${TEST_MANIFESTS}/standalone"
 
-  # Priority 1: TLS-enabled (mutually exclusive with other options)
+  # Priority 1.1: TLS-enabled (mutually exclusive with other options)
   if $POD_TO_POD_TLS_ENABLED; then
     TEST_MANIFESTS="${TEST_MANIFESTS}/tls-enabled"
 
-  # Priority 2: PostgreSQL + MinIO combination
-  elif [ "${DB_TYPE}" == "pgx" ] && [ "${STORAGE_BACKEND}" == "minio" ]; then
-    TEST_MANIFESTS="${TEST_MANIFESTS}/postgresql-minio"
-
-  # Priority 3: PostgreSQL (with default SeaweedFS storage)
+  # Priority 1.2: PostgreSQL (with default SeaweedFS storage)
   elif [ "${DB_TYPE}" == "pgx" ]; then
     TEST_MANIFESTS="${TEST_MANIFESTS}/postgresql"
 
-  # Priority 4: Check for cache-disabled + proxy + minio combination
+  # Priority 1.3: Check for cache-disabled + proxy + minio combination
   elif $CACHE_DISABLED && $USE_PROXY && [ "${STORAGE_BACKEND}" == "minio" ]; then
     TEST_MANIFESTS="${TEST_MANIFESTS}/cache-disabled-proxy-minio"
 
-  # Priority 5: Check for cache-disabled + proxy combination
+  # Priority 1.4: Check for cache-disabled + proxy combination
   elif $CACHE_DISABLED && $USE_PROXY; then
     TEST_MANIFESTS="${TEST_MANIFESTS}/cache-disabled-proxy"
 
-  # Priority 6: Check for cache-disabled + minio combination
+  # Priority 1.5: Check for cache-disabled + minio combination
   elif $CACHE_DISABLED && [ "${STORAGE_BACKEND}" == "minio" ]; then
     TEST_MANIFESTS="${TEST_MANIFESTS}/cache-disabled-minio"
 
-  # Priority 7: Check for proxy + minio combination
+  # Priority 1.6: Check for proxy + minio combination
   elif $USE_PROXY && [ "${STORAGE_BACKEND}" == "minio" ]; then
     TEST_MANIFESTS="${TEST_MANIFESTS}/proxy-minio"
 
-  # Priority 8: Check for single flags (cache-disabled, proxy, or minio)
+  # Priority 1.7: Check for single flags (cache-disabled, proxy, or minio)
   elif $CACHE_DISABLED; then
     TEST_MANIFESTS="${TEST_MANIFESTS}/cache-disabled"
   elif $USE_PROXY; then
@@ -185,37 +182,35 @@ if [ "${MULTI_USER}" == "false" ] && [ "${PIPELINES_STORE}" != "kubernetes" ]; t
   else
     TEST_MANIFESTS="${TEST_MANIFESTS}/default"
   fi
+# Priority 2: Multi-user false + kubernetes-native
 elif [ "${MULTI_USER}" == "false" ] && [ "${PIPELINES_STORE}" == "kubernetes" ]; then
   TEST_MANIFESTS="${TEST_MANIFESTS}/kubernetes-native"
   if $CACHE_DISABLED; then
     TEST_MANIFESTS="${TEST_MANIFESTS}/cache-disabled"
   else
     TEST_MANIFESTS="${TEST_MANIFESTS}/default"
   fi
+# Priority 3: Multi-user true
 elif [ "${MULTI_USER}" == "true" ]; then
   TEST_MANIFESTS="${TEST_MANIFESTS}/multiuser"
 
-  # Priority 1: PostgreSQL + MinIO
-  if [ "${DB_TYPE}" == "pgx" ] && [ "${STORAGE_BACKEND}" == "minio" ]; then
-    TEST_MANIFESTS="${TEST_MANIFESTS}/postgresql-minio"
-
-  # Priority 2: PostgreSQL (with default SeaweedFS)
-  elif [ "${DB_TYPE}" == "pgx" ]; then
+  # Priority 3.1: PostgreSQL (with default SeaweedFS)
+  if [ "${DB_TYPE}" == "pgx" ]; then
     TEST_MANIFESTS="${TEST_MANIFESTS}/postgresql"
 
-  # Priority 3: Artifact proxy (MySQL + SeaweedFS)
+  # Priority 3.2: Artifact proxy (MySQL + SeaweedFS)
   elif $ARTIFACT_PROXY_ENABLED && [ "${STORAGE_BACKEND}" == "seaweedfs" ]; then
     TEST_MANIFESTS="${TEST_MANIFESTS}/artifact-proxy"
 
-  # Priority 4: Cache disabled + MinIO (MySQL + MinIO)
+  # Priority 3.3: Cache disabled + MinIO (MySQL + MinIO)
   elif $CACHE_DISABLED && [ "${STORAGE_BACKEND}" == "minio" ]; then
     TEST_MANIFESTS="${TEST_MANIFESTS}/cache-disabled-minio"
 
-  # Priority 5: MinIO (MySQL + MinIO)
+  # Priority 3.4: MinIO (MySQL + MinIO)
   elif [ "${STORAGE_BACKEND}" == "minio" ]; then
     TEST_MANIFESTS="${TEST_MANIFESTS}/minio"
 
-  # Priority 6: Cache disabled (MySQL + SeaweedFS)
+  # Priority 3.5: Cache disabled (MySQL + SeaweedFS)
   elif $CACHE_DISABLED; then
     TEST_MANIFESTS="${TEST_MANIFESTS}/cache-disabled"
 

.github/resources/manifests/multiuser/postgresql-minio/kustomization.yaml

@@ -105,6 +105,8 @@ jobs:
             argo_version: "v3.6.7"
           - db_type: "pgx"
             argo_version: "v3.5.14"
+          - db_type: "pgx"
+            storage: "minio"
       fail-fast: false
     name: End to End ${{ matrix.test_label}} Tests - K8s ${{ matrix.k8s_version }} cacheEnabled=${{ matrix.cache_enabled }} argoVersion=${{ matrix.argo_version}} proxy=${{ matrix.proxy}} storage=${{ matrix.storage }} pod_to_pod_tls_enabled=${{ matrix.pod_to_pod_tls_enabled }} dbType=${{ matrix.db_type }}
     steps:
@@ -201,6 +203,9 @@ jobs:
             cache_enabled: "true"
             db_type: "mysql"
             test_label: "E2ECritical"
+        exclude:
+          - db_type: "pgx"
+            storage: "minio"
       fail-fast: false
     name: End to End Critical Scenario Multi User Tests - K8s ${{ matrix.k8s_version }} cacheEnabled=${{ matrix.cache_enabled }} multiUser=${{ matrix.multi_user }} storage=${{ matrix.storage }} artifactProxy=${{ matrix.artifact_proxy }} dbType=${{ matrix.db_type }}
     steps:

.github/resources/manifests/standalone/postgresql-minio/apiserver-env.yaml

@@ -52,7 +52,7 @@ jobs:
         if: ${{ matrix.db_type == 'pgx' }}
         uses: actions/setup-go@v5
         with:
-          go-version: "1.22"
+          go-version: "1.24"
           cache: true
 
       - name: Create KFP cluster

.github/resources/manifests/standalone/postgresql-minio/kustomization.yaml

@@ -51,7 +51,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.22"
+          go-version: "1.24"
           cache: true
 
       - name: Create KFP cluster

.github/resources/scripts/deploy-kfp.sh

@@ -45,27 +45,36 @@ func NewDBDialect(name string) DBDialect {
 	switch name {
 	case "mysql":
 		return DBDialect{
-			name:            "mysql",
-			quoteIdentifier: func(id string) string { return fmt.Sprintf("`%s`", id) },
-			lengthFunc:      "CHAR_LENGTH",
+			name: "mysql",
+			quoteIdentifier: func(id string) string {
+				escaped := strings.ReplaceAll(id, "`", "``")
+				return fmt.Sprintf("`%s`", escaped)
+			},
+			lengthFunc: "CHAR_LENGTH",
 			statementBuilder: sq.StatementBuilder.
 				PlaceholderFormat(sq.Question),
 			existDatabaseErrHint: "database exists",
 		}
 	case "pgx":
 		return DBDialect{
-			name:            "pgx",
-			quoteIdentifier: func(id string) string { return fmt.Sprintf(`"%s"`, id) },
-			lengthFunc:      "CHAR_LENGTH",
+			name: "pgx",
+			quoteIdentifier: func(id string) string {
+				escaped := strings.ReplaceAll(id, `"`, `""`)
+				return fmt.Sprintf(`"%s"`, escaped)
+			},
+			lengthFunc: "CHAR_LENGTH",
 			statementBuilder: sq.StatementBuilder.
 				PlaceholderFormat(sq.Dollar),
 			existDatabaseErrHint: "already exists",
 		}
 	case "sqlite": // only for tests
 		return DBDialect{
-			name:            "sqlite",
-			quoteIdentifier: func(id string) string { return fmt.Sprintf(`"%s"`, id) },
-			lengthFunc:      "LENGTH",
+			name: "sqlite",
+			quoteIdentifier: func(id string) string {
+				escaped := strings.ReplaceAll(id, `"`, `""`)
+				return fmt.Sprintf(`"%s"`, escaped)
+			},
+			lengthFunc: "LENGTH",
 			statementBuilder: sq.StatementBuilder.
 				PlaceholderFormat(sq.Question),
 			existDatabaseErrHint: "",