[bug] Kustomize build is displaying warnings for unsubstituted vars

[vikas-saxena02]

Environment

MacOS running kind

As part of kubeflow/manifests#2991 I am trying to fix up the kustomize warnings and come across this warning

The warning occurs in manifests/kustomize/base/installs/generic directory while running kustomize build .

Steps to reproduce

• navigate to manifests/kustomize/base/installs/generic dir
• execute kustomize build .

Expected result

The warning shouldnt have coccured in first place as all vars should have been substiiuted.
If I were to remove these vars with replacements, is it safe for me to ignore these vars and their replacements?
PS: unit tests in the CI peipline check for these vars so they cannot be safely ignored unless CI tests are updated. But the broader question is if its safe to remove these vars alltogather

Materials and reference

see screenshot attached

Labels

/area manifests

---

Impacted by this bug? Give it a 👍.

[Lucky-Lodhi2004]

/assign

I would like to work on this issue.

[vikas-saxena02]

@Lucky-Lodhi2004 any progress on the same?

[vikas-saxena02]

@droctothorpe just wondering if its safe to ignore these vars when chnaging vars to replacements?

[Lucky-Lodhi2004]

working on it, can't remove variables completely (may cause test failures).

[vikas-saxena02]

Thats tge whole point of the issue. The tests need to be updated.

[Lucky-Lodhi2004]

should i update them? also i think we need to replace 'vars' with 'replacements' in line 10 of /pipelines/manifests/kustomize/base/installs/generic/kustomization.yaml and /pipelines/manifests/kustomize/base/installs/generic/postgress/kustomization.yaml.

[Lucky-Lodhi2004]

I think we don't need to update tests in original pipelines repo, i am checking separate tests repo now.

[Lucky-Lodhi2004]

I have checked kubeflow/testing repository and it has its own separate module like /pipelines inside it. It is separate from this repo i.e

Removing the changes here may not reflect in the testing repository, so i think removing the parameters may not cause ci test failure.

now, i am raising a PR, let's see if some problem happens.