Skip condition update when succeeded (#173)

Author: johnugeorge

pkg/controller.v1/pytorch/status.go

@@ -203,8 +203,8 @@ func isFailed(status common.JobStatus) bool {
 // If the condition that we are about to add already exists
 // and has the same status and reason then we are not going to update.
 func setCondition(status *common.JobStatus, condition common.JobCondition) {
-	// Do nothing if PyTorchJobStatus have failed condition
-	if isFailed(*status) {
+	// Do nothing if PyTorchJobStatus is completed
+	if isFailed(*status) || isSucceeded(*status) {
 		return
 	}
 

pkg/controller.v1beta2/pytorch/status.go

@@ -203,8 +203,8 @@ func isFailed(status common.JobStatus) bool {
 // If the condition that we are about to add already exists
 // and has the same status and reason then we are not going to update.
 func setCondition(status *common.JobStatus, condition common.JobCondition) {
-	// Do nothing if PyTorchJobStatus have failed condition
-	if isFailed(*status) {
+	// Do nothing if PyTorchJobStatus is completed
+	if isFailed(*status) || isSucceeded(*status) {
 		return
 	}