Skip to content
This repository was archived by the owner on Sep 19, 2022. It is now read-only.

Commit d33e8ed

Browse files
johnugeorgek8s-ci-robot
authored andcommitted
Delete v1alpha1 API and Controller (#110)
* Delete v1alpha1 API and Controller * Minor fix
1 parent 8d71ff3 commit d33e8ed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+5
-4234
lines changed

.travis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ install:
2020
- gometalinter --install
2121

2222
script:
23-
- go build -o pytorch-operator github.com/kubeflow/pytorch-operator/cmd/pytorch-operator
2423
- go build -o pytorch-operator.v2 github.com/kubeflow/pytorch-operator/cmd/pytorch-operator.v2
2524
- go build -o pytorch-operator.v1beta1 github.com/kubeflow/pytorch-operator/cmd/pytorch-operator.v1beta1
2625
- gometalinter --config=linter_config.json ./pkg/...

build_image.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ echo "Create symlink to GOPATH"
2020
mkdir -p ${GOPATH}/src/github.com/kubeflow
2121
ln -s ${CONTEXT_DIR} ${GO_DIR}
2222
cd ${GO_DIR}
23-
echo "Build pytorch operator v1alpha1 binary"
24-
go build github.com/kubeflow/pytorch-operator/cmd/pytorch-operator
2523
echo "Build pytorch operator v1alpha2 binary"
2624
go build github.com/kubeflow/pytorch-operator/cmd/pytorch-operator.v2
25+
echo "Build pytorch operator v1beta1 binary"
26+
go build github.com/kubeflow/pytorch-operator/cmd/pytorch-operator.v1beta1
2727

2828
echo "Building container in gcloud"
2929
gcloud container builds submit . --tag=${IMAGE}:${TAG}

cmd/pytorch-operator/app/options/options.go

Lines changed: 0 additions & 45 deletions
This file was deleted.

cmd/pytorch-operator/app/server.go

Lines changed: 0 additions & 167 deletions
This file was deleted.

cmd/pytorch-operator/main.go

Lines changed: 0 additions & 48 deletions
This file was deleted.

cmd/pytorch-operator/pytorch-operator

-34.3 MB
Binary file not shown.

hack/update-codegen.sh

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,9 @@ CODEGEN_PKG=${CODEGEN_PKG:-$(cd ${SCRIPT_ROOT}; ls -d -1 ./vendor/k8s.io/code-ge
3030
# instead of the $GOPATH directly. For normal projects this can be dropped.
3131
${CODEGEN_PKG}/generate-groups.sh "defaulter,deepcopy,client,informer,lister" \
3232
github.com/kubeflow/pytorch-operator/pkg/client github.com/kubeflow/pytorch-operator/pkg/apis \
33-
pytorch:v1alpha1,v1alpha2,v1beta1 \
33+
pytorch:v1alpha2,v1beta1 \
3434
--go-header-file ${SCRIPT_ROOT}/hack/boilerplate/boilerplate.go.txt
3535

36-
echo "Generating defaulters for pytorch v1alpha1"
37-
${GOPATH}/bin/defaulter-gen --input-dirs github.com/kubeflow/pytorch-operator/pkg/apis/pytorch/v1alpha1 \
38-
-O zz_generated.defaults \
39-
--go-header-file ./hack/../hack/boilerplate/boilerplate.go.txt \
40-
--output-package github.com/kubeflow/pytorch-operator/pkg/apis/pytorch/v1alpha1
41-
42-
4336
echo "Generating defaulters for pytorch v1alpha2"
4437
${GOPATH}/bin/defaulter-gen --input-dirs github.com/kubeflow/pytorch-operator/pkg/apis/pytorch/v1alpha2 \
4538
-O zz_generated.defaults \

linter_config.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@
2222
"Exclude": [
2323
"redundant return statement",
2424
"comment or be unexported",
25-
"comment on exported",
26-
"pkg/apis/pytorch/v1alpha1/zz_generated.deepcopy.go",
27-
"pkg/apis/pytorch/v1alpha1/zz_generated.defaults.go"
25+
"comment on exported"
2826
],
2927
"Deadline": "300s",
3028
"Skip": ["pkg/client"]

0 commit comments

Comments
 (0)