Skip to content

Commit bfdd287

Browse files
committed
command type changes made with stream_logs docstring fix Signed-off-by: Nijeesh NJ <nijeesh10th@gmail.com>
1 parent 5cfb32e commit bfdd287

File tree

1 file changed

+4
-3
lines changed
  • kubeflow/trainer/backends/localprocess

1 file changed

+4
-3
lines changed

kubeflow/trainer/backends/localprocess/job.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class LocalJob(threading.Thread):
3232
def __init__(
3333
self,
3434
name: str,
35-
command: list[str] | tuple[str, ...] | str,
35+
command: list[str] | tuple[str, ...],
3636
execution_dir: str | None = None,
3737
env: dict[str, str] | None = None,
3838
dependencies: list[LocalJob] | None = None,
@@ -184,10 +184,11 @@ def logs(self, follow: bool = False) -> list[str]:
184184
return self._stdout.splitlines()
185185

186186
def stream_logs(self) -> Iterator[str]:
187-
"""Generate new output lines as they come in.
187+
"""Generate new output chunks of stdout as they come in.
188188
189189
Yields:
190-
New output chunks from the job.
190+
New output chunks from the job (may contain partial or multiple
191+
lines).
191192
"""
192193
last_index = 0
193194
while self.is_alive() or last_index < len(self._stdout):

0 commit comments

Comments
 (0)