Skip to content

Commit 45966fe

Browse files
authored
fix: use global rank for dataset download guard in container backend notebook (#3418)
Signed-off-by: Fiona-Waters <fiwaters6@gmail.com>
1 parent f7d3bbb commit 45966fe

1 file changed

Lines changed: 6 additions & 10 deletions

File tree

examples/local/local-container-mnist.ipynb

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -108,16 +108,12 @@
108108
" model = nn.parallel.DistributedDataParallel(model)\n",
109109
" optimizer = optim.SGD(model.parameters(), lr=0.01, momentum=0.5)\n",
110110
"\n",
111-
" # Download FashionMNIST dataset only on local_rank=0 process.\n",
112-
" if local_rank == 0:\n",
113-
" dataset = datasets.FashionMNIST(\n",
111+
" # Download FashionMNIST dataset only on global rank 0 process.\n",
112+
" if dist.get_rank() == 0:\n",
113+
" datasets.FashionMNIST(\n",
114114
" \"./data\",\n",
115115
" train=True,\n",
116116
" download=True,\n",
117-
" transform=transforms.Compose([\n",
118-
" transforms.ToTensor(),\n",
119-
" transforms.Normalize((0.1307,), (0.3081,)),\n",
120-
" ]),\n",
121117
" )\n",
122118
" dist.barrier()\n",
123119
" dataset = datasets.FashionMNIST(\n",
@@ -127,7 +123,7 @@
127123
" transform=transforms.Compose([transforms.ToTensor()]),\n",
128124
" )\n",
129125
"\n",
130-
" # Shard the dataset accross workers.\n",
126+
" # Shard the dataset across workers.\n",
131127
" train_loader = DataLoader(\n",
132128
" dataset,\n",
133129
" batch_size=100,\n",
@@ -374,7 +370,7 @@
374370
],
375371
"metadata": {
376372
"kernelspec": {
377-
"display_name": "Python 3 (ipykernel)",
373+
"display_name": "Python 3",
378374
"language": "python",
379375
"name": "python3"
380376
},
@@ -388,7 +384,7 @@
388384
"name": "python",
389385
"nbconvert_exporter": "python",
390386
"pygments_lexer": "ipython3",
391-
"version": "3.11.13"
387+
"version": "3.13.7"
392388
}
393389
},
394390
"nbformat": 4,

0 commit comments

Comments
 (0)