fix(sdk): always add queue label regardless of queue existence (#3221)

Fixes #2775

Signed-off-by: Pavan More <pavansmore05@gmail.com>

Author: puwun

sdk/python/kubeflow/training/api/training_client.py

@@ -598,12 +598,11 @@ def create_job(
             )
 
         # Handle Kueue queue validation and labeling
-        if queue_name is not None:
-            queue_exists = self._check_queue_exists(queue_name, namespace)
-            if queue_exists is not False:
-                if job.metadata.labels is None:
-                    job.metadata.labels = {}
-                job.metadata.labels[constants.LOCAL_QUEUE_LABEL] = queue_name
+        if queue_name and queue_name.strip():
+            self._check_queue_exists(queue_name, namespace)
+            if job.metadata.labels is None:
+                job.metadata.labels = {}
+            job.metadata.labels[constants.LOCAL_QUEUE_LABEL] = queue_name
 
         # Create the Training Job.
         try:

sdk/python/kubeflow/training/api/training_client_test.py

@@ -697,6 +697,21 @@ def __init__(self):
             labels=None,
         ),
     ),
+    (
+        "valid flow with empty queue name",
+        {
+            "name": TEST_NAME,
+            "namespace": TEST_NAME,
+            "base_image": TEST_IMAGE,
+            "num_workers": 1,
+            "queue_name": "",
+        },
+        SUCCESS,
+        create_job(
+            num_workers=1,
+            labels=None,
+        ),
+    ),
     (
         "valid flow with non-existent queue",
         {
@@ -709,7 +724,7 @@ def __init__(self):
         SUCCESS,
         create_job(
             num_workers=1,
-            labels=None,
+            labels={constants.LOCAL_QUEUE_LABEL: "non-existent-queue"},
         ),
     ),
     (