diff --git a/pkg/apis/trainer/v1alpha1/trainjob_types.go b/pkg/apis/trainer/v1alpha1/trainjob_types.go index 86e378c7e3..07ec9a2d7b 100644 --- a/pkg/apis/trainer/v1alpha1/trainjob_types.go +++ b/pkg/apis/trainer/v1alpha1/trainjob_types.go @@ -194,6 +194,8 @@ type Initializer struct { // which contains this label: `trainer.kubeflow.org/trainjob-ancestor-step: dataset-initializer` type DatasetInitializer struct { // storageUri is the URI for the dataset provider. + // Should be a valid URI format (e.g., s3://bucket/path, gs://bucket/path, /local/path) + // +kubebuilder:validation:Pattern=`^([A-Za-z][A-Za-z0-9+.-]*://.+|/.*)$` // +kubebuilder:validation:MaxLength=2048 // +optional StorageUri *string `json:"storageUri,omitempty"` @@ -340,6 +342,7 @@ type JobSetSpecPatch struct { type ReplicatedJobPatch struct { // name is the name of the replicated job to patch. // +kubebuilder:validation:MinLength=1 + // +kubebuilder:validation:Pattern=`^[a-z0-9]([-a-z0-9]*[a-z0-9])?$` // +kubebuilder:validation:MaxLength=253 // +required Name string `json:"name,omitempty"`