Skip to content

Commit 3d457eb

Browse files
committed
fix vpc egress gateway not applied to new pods
Signed-off-by: zhangzujian <[email protected]>
1 parent 663e8cd commit 3d457eb

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

pkg/controller/vpc_egress_gateway.go

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -986,19 +986,24 @@ func (c *Controller) handlePodEventForVpcEgressGateway(pod *corev1.Pod) error {
986986
}
987987

988988
for _, selector := range veg.Spec.Selectors {
989-
sel, err := metav1.LabelSelectorAsSelector(selector.NamespaceSelector)
990-
if err != nil {
991-
klog.Errorf("failed to create label selector for namespace selector %#v: %v", selector.NamespaceSelector, err)
992-
utilruntime.HandleError(err)
993-
continue
989+
sel := labels.Everything()
990+
if selector.NamespaceSelector != nil {
991+
if sel, err = metav1.LabelSelectorAsSelector(selector.NamespaceSelector); err != nil {
992+
klog.Errorf("failed to create label selector for namespace selector %#v: %v", selector.NamespaceSelector, err)
993+
utilruntime.HandleError(err)
994+
continue
995+
}
994996
}
995997
if !sel.Matches(labels.Set(ns.Labels)) {
996998
continue
997999
}
998-
if sel, err = metav1.LabelSelectorAsSelector(selector.PodSelector); err != nil {
999-
klog.Errorf("failed to create label selector for pod selector %#v: %v", selector.PodSelector, err)
1000-
utilruntime.HandleError(err)
1001-
continue
1000+
sel = labels.Everything()
1001+
if selector.PodSelector != nil {
1002+
if sel, err = metav1.LabelSelectorAsSelector(selector.PodSelector); err != nil {
1003+
klog.Errorf("failed to create label selector for pod selector %#v: %v", selector.PodSelector, err)
1004+
utilruntime.HandleError(err)
1005+
continue
1006+
}
10021007
}
10031008
if sel.Matches(labels.Set(pod.Labels)) {
10041009
c.addOrUpdateVpcEgressGatewayQueue.Add(cache.MetaObjectToName(veg).String())

0 commit comments

Comments
 (0)