Skip to content

Commit 4bb73df

Browse files
oilbeaterclaude
andcommitted
fix(controller): add finish logs for all gc functions
All gc functions only had "start to gc ..." logs without corresponding completion logs, making it difficult to determine whether a gc cycle completed successfully or hung. Add "finish to gc ..." logs before each successful return to improve observability and debugging. Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
1 parent 0074ae3 commit 4bb73df

File tree

1 file changed

+20
-0
lines changed

1 file changed

+20
-0
lines changed

pkg/controller/gc.go

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ func (c *Controller) gcLogicalRouterPort() error {
8181
klog.Errorf("delete non-existent peer logical router port: %v", err)
8282
return err
8383
}
84+
klog.Infof("finish to gc logical router port")
8485
return nil
8586
}
8687

@@ -124,6 +125,7 @@ func (c *Controller) gcVpcNatGateway() error {
124125
}
125126
}
126127
}
128+
klog.Infof("finish to gc vpc nat gateway")
127129
return nil
128130
}
129131

@@ -166,6 +168,7 @@ func (c *Controller) gcLogicalSwitch() error {
166168
return err
167169
}
168170
}
171+
klog.Infof("finish to gc logical switch")
169172

170173
klog.Infof("start to gc dhcp options")
171174
dhcpOptions, err := c.OVNNbClient.ListDHCPOptions(c.config.EnableExternalVpc, nil)
@@ -186,6 +189,7 @@ func (c *Controller) gcLogicalSwitch() error {
186189
return err
187190
}
188191
}
192+
klog.Infof("finish to gc dhcp options")
189193
return nil
190194
}
191195

@@ -222,6 +226,7 @@ func (c *Controller) gcCustomLogicalRouter() error {
222226
return err
223227
}
224228
}
229+
klog.Infof("finish to gc logical router")
225230
return nil
226231
}
227232

@@ -280,6 +285,7 @@ func (c *Controller) gcNode() error {
280285
}
281286
}
282287

288+
klog.Infof("finish to gc nodes")
283289
return nil
284290
}
285291

@@ -308,13 +314,15 @@ func (c *Controller) gcVip() error {
308314
klog.Errorf("failed to clean label from vip %s, %v", vip.Name, err)
309315
return err
310316
}
317+
klog.Infof("finish to gc vips")
311318
return nil
312319
}
313320
klog.Error(err)
314321
return err
315322
}
316323
}
317324
}
325+
klog.Infof("finish to gc vips")
318326
return nil
319327
}
320328

@@ -416,6 +424,7 @@ func (c *Controller) gcIP() error {
416424
}
417425
}
418426
}
427+
klog.Infof("finish to gc ips")
419428
return nil
420429
}
421430

@@ -566,6 +575,7 @@ func (c *Controller) markAndCleanLSP() error {
566575
return true
567576
})
568577

578+
klog.V(4).Infof("finish to gc logical switch ports")
569579
return nil
570580
}
571581

@@ -640,6 +650,7 @@ func (c *Controller) gcLoadBalancer() error {
640650
klog.Errorf("delete all load balancers: %v", err)
641651
return err
642652
}
653+
klog.Infof("finish to gc load balancers")
643654
return nil
644655
}
645656

@@ -770,6 +781,7 @@ func (c *Controller) gcLoadBalancer() error {
770781
klog.Errorf("delete load balancers: %v", err)
771782
return err
772783
}
784+
klog.Infof("finish to gc load balancers")
773785
return nil
774786
}
775787

@@ -804,6 +816,7 @@ func (c *Controller) gcAddressSet() error {
804816
return err
805817
}
806818

819+
klog.Infof("finish to gc address set")
807820
return nil
808821
}
809822

@@ -848,6 +861,7 @@ func (c *Controller) gcSecurityGroup() error {
848861
klog.Errorf("failed to gc port group list,%v", err)
849862
return err
850863
}
864+
klog.Infof("finish to gc security group residual port groups")
851865
return nil
852866
}
853867

@@ -932,6 +946,7 @@ func (c *Controller) gcNetworkPolicy() error {
932946
return err
933947
}
934948

949+
klog.Infof("finish to gc network policy")
935950
return nil
936951
}
937952

@@ -971,6 +986,7 @@ func (c *Controller) gcRoutePolicy() error {
971986
}
972987
}
973988

989+
klog.Infof("finish to gc route policy")
974990
return nil
975991
}
976992

@@ -1019,6 +1035,7 @@ func (c *Controller) gcStaticRoute() error {
10191035
}
10201036
}
10211037
}
1038+
klog.Infof("finish to gc static routes")
10221039
return nil
10231040
}
10241041

@@ -1066,6 +1083,7 @@ func (c *Controller) gcChassis() error {
10661083
}
10671084
}
10681085

1086+
klog.Infof("finish to gc chassis")
10691087
return nil
10701088
}
10711089

@@ -1186,6 +1204,7 @@ func (c *Controller) gcLbSvcPods() error {
11861204
}
11871205
}
11881206
}
1207+
klog.Infof("finish to gc lb svc pods")
11891208
return nil
11901209
}
11911210

@@ -1253,6 +1272,7 @@ func (c *Controller) gcVPCDNS() error {
12531272
}
12541273
}
12551274
}
1275+
klog.Infof("finish to gc vpc dns")
12561276
return nil
12571277
}
12581278

0 commit comments

Comments
 (0)