fix: require cluster-as and neighbor-as parameters in configuration

Signed-off-by: zbb88888 <jmdxjsjgcxy@gmail.com>

Author: zbb88888

pkg/speaker/config.go

@@ -28,8 +28,6 @@ import (
 
 const (
 	DefaultBGPGrpcPort                 = 50051
-	DefaultBGPClusterAs                = 65000
-	DefaultBGPNeighborAs               = 65001
 	DefaultBGPHoldtime                 = 90 * time.Second
 	DefaultPprofPort                   = 10667
 	DefaultGracefulRestartDeferralTime = 360 * time.Second
@@ -77,12 +75,12 @@ func ParseFlags() (*Configuration, error) {
 		argAnnounceClusterIP           = pflag.BoolP("announce-cluster-ip", "", false, "The Cluster IP of the service to announce to the BGP peers.")
 		argGrpcHost                    = pflag.IP("grpc-host", net.IP{127, 0, 0, 1}, "The host address for grpc to listen, default: 127.0.0.1")
 		argGrpcPort                    = pflag.Int32("grpc-port", DefaultBGPGrpcPort, "The port for grpc to listen, default:50051")
-		argClusterAs                   = pflag.Uint32("cluster-as", DefaultBGPClusterAs, "The AS number of container network, default 65000")
+		argClusterAs                   = pflag.Uint32("cluster-as", 0, "The AS number of the local BGP speaker (required)")
 		argRouterID                    = pflag.IP("router-id", nil, "The address for the speaker to use as router id, default the node ip")
 		argNodeIPs                     = pflag.IPSlice("node-ips", nil, "The comma-separated list of node IP addresses to use instead of the pod IP address for the next hop router IP address.")
 		argNeighborAddress             = pflag.IPSlice("neighbor-address", nil, "Comma separated IPv4 router addresses the speaker connects to.")
 		argNeighborIPv6Address         = pflag.IPSlice("neighbor-ipv6-address", nil, "Comma separated IPv6 router addresses the speaker connects to.")
-		argNeighborAs                  = pflag.Uint32("neighbor-as", DefaultBGPNeighborAs, "The router as number, default 65001")
+		argNeighborAs                  = pflag.Uint32("neighbor-as", 0, "The AS number of the BGP neighbor/peer (required)")
 		argAuthPassword                = pflag.String("auth-password", "", "bgp peer auth password")
 		argHoldTime                    = pflag.Duration("holdtime", DefaultBGPHoldtime, "ovn-speaker goes down abnormally, the local saving time of BGP route will be affected.Holdtime must be in the range 3s to 65536s. (default 90s)")
 		argPprofPort                   = pflag.Int32("pprof-port", DefaultPprofPort, "The port to get profiling data, default: 10667")
@@ -169,8 +167,8 @@ func ParseFlags() (*Configuration, error) {
 		LogPerm:                     *argLogPerm,
 	}
 
-	if len(config.NeighborAddresses) == 0 && len(config.NeighborIPv6Addresses) == 0 {
-		return nil, errors.New("at least one of --neighbor-address or --neighbor-ipv6-address must be specified")
+	if err := config.validateRequiredFlags(); err != nil {
+		return nil, err
 	}
 
 	for _, addr := range config.NeighborAddresses {
@@ -206,6 +204,27 @@ func ParseFlags() (*Configuration, error) {
 	return config, nil
 }
 
+// validateRequiredFlags checks that all required BGP configuration flags are provided.
+// It collects all missing flags and returns them in a single error message.
+func (config *Configuration) validateRequiredFlags() error {
+	var missingFlags []string
+
+	if len(config.NeighborAddresses) == 0 && len(config.NeighborIPv6Addresses) == 0 {
+		missingFlags = append(missingFlags, "at least one of --neighbor-address or --neighbor-ipv6-address must be specified")
+	}
+	if config.ClusterAs == 0 {
+		missingFlags = append(missingFlags, "--cluster-as must be specified")
+	}
+	if config.NeighborAs == 0 {
+		missingFlags = append(missingFlags, "--neighbor-as must be specified")
+	}
+
+	if len(missingFlags) > 0 {
+		return fmt.Errorf("missing required flags: %s", strings.Join(missingFlags, "; "))
+	}
+	return nil
+}
+
 func (config *Configuration) initKubeClient() error {
 	var cfg *rest.Config
 	var err error