fix as review

zbb88888 · zbb88888 · commit 7d91766938a2 · 2025-04-13T11:03:13.000+08:00
Signed-off-by: zbb88888 &lt;jmdxjsjgcxy@gmail.com&gt;
diff --git a/dist/images/install.sh b/dist/images/install.sh
@@ -69,6 +69,7 @@ CNI_BIN_DIR="/opt/cni/bin"
 REGISTRY="docker.io/kubeovn"
 VPC_NAT_IMAGE="vpc-nat-gateway"
 VERSION="v1.14.0"
+VERSION="dev"
 IMAGE_PULL_POLICY="IfNotPresent"
 POD_CIDR="10.16.0.0/16"                     # Do NOT overlap with NODE/SVC/JOIN CIDR
 POD_GATEWAY="10.16.0.1"
diff --git a/pkg/controller/vip.go b/pkg/controller/vip.go
@@ -89,7 +89,7 @@ func (c *Controller) handleAddVirtualIP(key string) error {
 	}
 	var macPointer *string
 	ipStr := util.GetStringIP(sourceV4Ip, sourceV6Ip)
-	if ipStr != "" && vip.Spec.MacAddress != "" {
+	if ipStr != "" || vip.Spec.MacAddress != "" {
 		macPointer = &vip.Spec.MacAddress
 		v4ip, v6ip, mac, err = c.acquireStaticIPAddress(subnet.Name, vip.Name, portName, ipStr, macPointer)
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ func (c *Controller) handleAddVirtualIP(key string) error {`
`89`	`89`	`}`
`90`	`90`	`var macPointer *string`
`91`	`91`	`ipStr := util.GetStringIP(sourceV4Ip, sourceV6Ip)`
`92`		`- if ipStr != "" && vip.Spec.MacAddress != "" {`
	`92`	`+ if ipStr != "" \|\| vip.Spec.MacAddress != "" {`
`93`	`93`	`macPointer = &vip.Spec.MacAddress`
`94`	`94`	`v4ip, v6ip, mac, err = c.acquireStaticIPAddress(subnet.Name, vip.Name, portName, ipStr, macPointer)`
`95`	`95`	`} else {`