fix: add validation to prevent subnet and VPC with the same name (#5371)

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

Author: oilbeater

pkg/util/validator.go

@@ -119,6 +119,10 @@ func ValidateSubnet(subnet kubeovnv1.Subnet) error {
 		return fmt.Errorf("%s is not a valid protocol type", protocol)
 	}
 
+	if subnet.Spec.Vpc == subnet.Name {
+		return fmt.Errorf("subnet %s and vpc %s cannot have the same name", subnet.Name, subnet.Spec.Vpc)
+	}
+
 	if subnet.Spec.Vpc == DefaultVpc {
 		k8sAPIServer := os.Getenv("KUBERNETES_SERVICE_HOST")
 		if k8sAPIServer != "" && CIDRContainIP(subnet.Spec.CIDRBlock, k8sAPIServer) {

pkg/util/validator_test.go

@@ -225,6 +225,50 @@ func TestValidateSubnet(t *testing.T) {
 			},
 			err: "ipv5 is not a valid protocol type",
 		},
+		{
+			name: "SubnetVpcSameNameErr",
+			asubnet: kubeovnv1.Subnet{
+				TypeMeta: metav1.TypeMeta{Kind: "Subnet", APIVersion: "kubeovn.io/v1"},
+				ObjectMeta: metav1.ObjectMeta{
+					Name: "same-name",
+				},
+				Spec: kubeovnv1.SubnetSpec{
+					Default:     true,
+					Vpc:         "same-name",
+					Protocol:    kubeovnv1.ProtocolIPv4,
+					Namespaces:  nil,
+					CIDRBlock:   "10.16.0.0/16",
+					Gateway:     "10.16.0.1",
+					ExcludeIps:  []string{"10.16.0.1"},
+					Provider:    "ovn",
+					GatewayType: kubeovnv1.GWDistributedType,
+				},
+				Status: kubeovnv1.SubnetStatus{},
+			},
+			err: "subnet same-name and vpc same-name cannot have the same name",
+		},
+		{
+			name: "SubnetVpcDifferentNameCorrect",
+			asubnet: kubeovnv1.Subnet{
+				TypeMeta: metav1.TypeMeta{Kind: "Subnet", APIVersion: "kubeovn.io/v1"},
+				ObjectMeta: metav1.ObjectMeta{
+					Name: "subnet-name",
+				},
+				Spec: kubeovnv1.SubnetSpec{
+					Default:     true,
+					Vpc:         "vpc-name",
+					Protocol:    kubeovnv1.ProtocolIPv4,
+					Namespaces:  nil,
+					CIDRBlock:   "10.16.0.0/16",
+					Gateway:     "10.16.0.1",
+					ExcludeIps:  []string{"10.16.0.1"},
+					Provider:    "ovn",
+					GatewayType: kubeovnv1.GWDistributedType,
+				},
+				Status: kubeovnv1.SubnetStatus{},
+			},
+			err: "",
+		},
 		{
 			name: "ExternalEgressGatewayUpperCaseErr",
 			asubnet: kubeovnv1.Subnet{