Skip to content

Commit dd79c77

Browse files
fix(netpol): don't check if rules already exist in lax mode (#5802)
Signed-off-by: SkalaNetworks <[email protected]>
1 parent d7e2057 commit dd79c77

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/ovs/ovn-nb-acl.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,13 @@ func (c *OVNNbClient) UpdateDefaultBlockACLOps(npName, pgName, direction string,
112112
// UpdateDefaultBlockExceptionsACLOps updates the exceptions to the default block ACLs of a NetworkPolicy to allow DHCPv4/DHCPv6.
113113
func (c *OVNNbClient) UpdateDefaultBlockExceptionsACLOps(npName, pgName, npNamespace, direction string) ([]ovsdb.Operation, error) {
114114
portDirection := "outport"
115+
priority := util.IngressAllowPriority
115116
dhcpv4UdpSrc, dhcpv4UdpDst := "67", "68"
116117
dhcpv6UdpSrc, dhcpv6UdpDst := "547", "546"
117118

118119
if direction == ovnnb.ACLDirectionFromLport { // Egress rule
119120
portDirection = "inport"
121+
priority = util.EgressAllowPriority
120122
dhcpv4UdpSrc, dhcpv4UdpDst = dhcpv4UdpDst, dhcpv4UdpSrc
121123
dhcpv6UdpSrc, dhcpv6UdpDst = dhcpv6UdpDst, dhcpv6UdpSrc
122124
}
@@ -128,7 +130,7 @@ func (c *OVNNbClient) UpdateDefaultBlockExceptionsACLOps(npName, pgName, npNames
128130
setACLName(acl, npName)
129131
}
130132

131-
acl, err := c.newACL(pgName, direction, util.IngressAllowPriority, match, ovnnb.ACLActionAllowRelated, util.NetpolACLTier, options)
133+
acl, err := c.newACLWithoutCheck(pgName, direction, priority, match, ovnnb.ACLActionAllowRelated, util.NetpolACLTier, options)
132134
if err != nil {
133135
klog.Error(err)
134136
klog.Errorf("failed to create new block exceptions acl for network policy %s/%s: %v", npNamespace, npName, err)

0 commit comments

Comments
 (0)