fix(controller): prevent NPE in isOvnSubnet when subnet is nil

oilbeater · claude · oilbeater · commit ecfce509064b · 2026-02-21T12:33:39.000Z
When an IP CR references a deleted subnet, handleUpdateIP calls isOvnSubnet with a nil subnet pointer, causing a panic that puts the controller into CrashLoopBackOff. Add a nil check so that isOvnSubnet safely returns false for nil input. Fixes #6309 Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
diff --git a/pkg/controller/subnet.go b/pkg/controller/subnet.go
@@ -2372,7 +2372,7 @@ func (c *Controller) checkSubnetUsingIPs(subnet *kubeovnv1.Subnet) error {
 }
 
 func isOvnSubnet(subnet *kubeovnv1.Subnet) bool {
-	return util.IsOvnProvider(subnet.Spec.Provider)
+	return subnet != nil && util.IsOvnProvider(subnet.Spec.Provider)
 }
 
 func checkAndFormatsExcludeIPs(subnet *kubeovnv1.Subnet) bool {

Original file line number	Diff line number	Diff line change
`@@ -2372,7 +2372,7 @@ func (c Controller) checkSubnetUsingIPs(subnet kubeovnv1.Subnet) error {`
`2372`	`2372`	`}`
`2373`	`2373`
`2374`	`2374`	`func isOvnSubnet(subnet *kubeovnv1.Subnet) bool {`
`2375`		`- return util.IsOvnProvider(subnet.Spec.Provider)`
	`2375`	`+ return subnet != nil && util.IsOvnProvider(subnet.Spec.Provider)`
`2376`	`2376`	`}`
`2377`	`2377`
`2378`	`2378`	`func checkAndFormatsExcludeIPs(subnet *kubeovnv1.Subnet) bool {`