chore: fix linting issues and formatting

Signed-off-by: abasitt <abdul.basit@rakuten.com>

Author: abasitt

pkg/apis/kubeovn/v1/provider-network.go

@@ -40,7 +40,7 @@ type ProviderNetworkSpec struct {
 	// Enable automatic detection and preservation of existing VLAN interfaces on the default interface
 	PreserveVlanInterfaces bool `json:"preserveVlanInterfaces,omitempty"`
 	// Explicit list of VLAN interface names to preserve (e.g., eth0.10, bond0.20)
-	VlanInterfaces   []string          `json:"vlanInterfaces,omitempty"`
+	VlanInterfaces []string `json:"vlanInterfaces,omitempty"`
 }
 
 type ProviderNetworkCondition struct {

pkg/apis/kubeovn/v1/register_test.go

@@ -81,8 +81,8 @@ func TestAddResources(t *testing.T) {
 		}
 
 		var hasTypeMeta, hasObjMeta, hasListMeta bool
-		for i := range st.NumFields() {
-			v := st.Field(i)
+		for v := range st.Fields() {
+			v := v
 			if !v.Embedded() || !v.Exported() {
 				continue
 			}

pkg/controller/deployment.go

@@ -18,12 +18,12 @@ var (
 )
 
 func init() {
-	name := reflect.TypeOf(&appsv1.Deployment{}).Elem().Name()
+	name := reflect.TypeFor[appsv1.Deployment]().Name()
 	gvk := appsv1.SchemeGroupVersion.WithKind(name)
 	deploymentGroupVersion = gvk.GroupVersion().String()
 	deploymentKind = gvk.Kind
 
-	name = reflect.TypeOf(&kubeovnv1.VpcEgressGateway{}).Elem().Name()
+	name = reflect.TypeFor[kubeovnv1.VpcEgressGateway]().Name()
 	gvk = kubeovnv1.SchemeGroupVersion.WithKind(name)
 	vpcEgressGatewayGroupVersion = gvk.GroupVersion().String()
 	vpcEgressGatewayKind = gvk.Kind

pkg/daemon/init.go

@@ -97,7 +97,7 @@ func InitMirror(config *Configuration) error {
 	return configureEmptyMirror(config.MirrorNic, config.MTU)
 }
 
-func (c *Controller) ovsInitProviderNetwork(provider, nic string, trunks []string, exchangeLinkName, macLearningFallback bool, vlanInterfaceMap map[string]int) (int, error) {	// create and configure external bridge
+func (c *Controller) ovsInitProviderNetwork(provider, nic string, trunks []string, exchangeLinkName, macLearningFallback bool, vlanInterfaceMap map[string]int) (int, error) { // create and configure external bridge
 	brName := util.ExternalBridgeName(provider)
 	if exchangeLinkName {
 		exchanged, err := c.changeProvideNicName(nic, brName)

pkg/daemon/ovs_linux.go

@@ -1950,10 +1950,12 @@ func (c *Controller) configProviderVlanInterfaces(vlanInterfaceMap map[string]in
 		internalPortName := fmt.Sprintf("%s-vlan%d", brName, vlanID)
 
 		// Create OVS internal port
-		args := []string{ovs.MayExist, "add-port", brName, internalPortName,
+		args := []string{
+			ovs.MayExist, "add-port", brName, internalPortName,
 			"--", "set", "interface", internalPortName, "type=internal",
 			"--", "set", "port", internalPortName, fmt.Sprintf("tag=%d", vlanID),
-			"external_ids:vendor=" + util.CniTypeName}
+			"external_ids:vendor=" + util.CniTypeName,
+		}
 
 		if _, err := ovs.Exec(args...); err != nil {
 			klog.Errorf("failed to create OVS internal port %s: %v", internalPortName, err)
@@ -2163,4 +2165,4 @@ func (c *Controller) removeProviderVlanInterface(internalPortName, brName string
 	}
 
 	return nil
-}
+}

pkg/util/ippool.go

@@ -161,11 +161,11 @@ func ipToCIDR(value string) (string, error) {
 // simplifyOVNAddress removes /32 and /128 suffixes for single IP addresses in OVN address sets.
 // OVN accepts both "10.0.0.1" and "10.0.0.1/32", but the former is simpler.
 func simplifyOVNAddress(cidr string) string {
-	if strings.HasSuffix(cidr, "/32") {
-		return strings.TrimSuffix(cidr, "/32")
+	if before, ok := strings.CutSuffix(cidr, "/32"); ok {
+		return before
 	}
-	if strings.HasSuffix(cidr, "/128") {
-		return strings.TrimSuffix(cidr, "/128")
+	if before, ok := strings.CutSuffix(cidr, "/128"); ok {
+		return before
 	}
 	return cidr
 }

pkg/util/vlan_interfaces_test.go

@@ -180,4 +180,4 @@ func TestExtractVlanIDFromInterface(t *testing.T) {
 			}
 		})
 	}
-}
+}

test/e2e/framework/http/http.go

@@ -1,3 +1,4 @@
+//nolint:revive // existing package name conflict
 package http
 
 import (

test/e2e/framework/iproute/iproute.go

@@ -182,7 +182,7 @@ func RouteShow(table, device string, execFunc ExecFunc) ([]Route, error) {
 		// ignore the following error:
 		// Error: ipv4/ipv6: FIB table does not exist.
 		// Dump terminated
-		e.ignoredErrors = append(e.ignoredErrors, reflect.TypeOf(docker.ErrNonZeroExitCode{}))
+		e.ignoredErrors = append(e.ignoredErrors, reflect.TypeFor[docker.ErrNonZeroExitCode]())
 		args = " table " + table
 	}
 	args += devArg(device)

test/e2e/vpc-egress-gateway/e2e_test.go

@@ -511,7 +511,7 @@ func vegTest(f *framework.Framework, bfd bool, provider, nadName, vpcName, inter
 	deploy := deployClient.Get(veg.Status.Workload.Name)
 	framework.ExpectEqual(deploy.Status.Replicas, replicas)
 	framework.ExpectEqual(deploy.Status.ReadyReplicas, replicas)
-	gvk := appsv1.SchemeGroupVersion.WithKind(reflect.TypeOf(deploy).Elem().Name())
+	gvk := appsv1.SchemeGroupVersion.WithKind(reflect.TypeFor[appsv1.Deployment]().Name())
 	framework.ExpectEqual(veg.Status.Workload.APIVersion, gvk.GroupVersion().String())
 	framework.ExpectEqual(veg.Status.Workload.Kind, gvk.Kind)
 	framework.ExpectHaveLen(veg.Status.Workload.Nodes, int(replicas))