Skip to content

Commit 3874c54

Browse files
authored
Merge pull request #1100 from andyzhangx/revert-move-nodeDriverRegistrar
Revert "refactor: move nodeDriverRegistrar config under node section"
2 parents 1494711 + ccef292 commit 3874c54

4 files changed

Lines changed: 23 additions & 22 deletions

File tree

charts/README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,12 +92,12 @@ The following table lists the configurable parameters of the latest NFS CSI Driv
9292
| `controller.resources.nfs.limits.memory` | csi-driver-nfs memory limits | 200Mi |
9393
| `controller.resources.nfs.requests.cpu` | csi-driver-nfs cpu requests limits | 10m |
9494
| `controller.resources.nfs.requests.memory` | csi-driver-nfs memory requests limits | 20Mi |
95-
| `node.nodeDriverRegistrar.healthPort` | health check port for node-driver-registrar liveness probe | `19809` |
96-
| `node.nodeDriverRegistrar.livenessProbe.enabled` | enable node-driver-registrar liveness probe | `false` |
97-
| `node.nodeDriverRegistrar.livenessProbe.initialDelaySeconds` | node-driver-registrar liveness probe initialDelaySeconds | `20` |
98-
| `node.nodeDriverRegistrar.livenessProbe.timeoutSeconds` | node-driver-registrar liveness probe timeoutSeconds | `10` |
99-
| `node.nodeDriverRegistrar.livenessProbe.periodSeconds` | node-driver-registrar liveness probe periodSeconds | `20` |
100-
| `node.nodeDriverRegistrar.livenessProbe.failureThreshold` | node-driver-registrar liveness probe failureThreshold | `2` |
95+
| `nodeDriverRegistrar.healthPort` | health check port for node-driver-registrar liveness probe | `19809` |
96+
| `nodeDriverRegistrar.livenessProbe.enabled` | enable node-driver-registrar liveness probe | `false` |
97+
| `nodeDriverRegistrar.livenessProbe.initialDelaySeconds` | node-driver-registrar liveness probe initialDelaySeconds | `20` |
98+
| `nodeDriverRegistrar.livenessProbe.timeoutSeconds` | node-driver-registrar liveness probe timeoutSeconds | `10` |
99+
| `nodeDriverRegistrar.livenessProbe.periodSeconds` | node-driver-registrar liveness probe periodSeconds | `20` |
100+
| `nodeDriverRegistrar.livenessProbe.failureThreshold` | node-driver-registrar liveness probe failureThreshold | `2` |
101101
| `node.name` | driver node daemonset name | `csi-nfs-node`
102102
| `node.dnsPolicy` | dnsPolicy of driver node daemonset, available values: `Default`, `ClusterFirstWithHostNet`, `ClusterFirst` |`ClusterFirstWithHostNet`
103103
| `node.maxUnavailable` | `maxUnavailable` value of driver node daemonset | `1`
-7 Bytes
Binary file not shown.

charts/latest/csi-driver-nfs/templates/csi-nfs-node.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@ spec:
7474
- --v=2
7575
- --csi-address=/csi/csi.sock
7676
- --kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)
77-
{{- if .Values.node.nodeDriverRegistrar.livenessProbe.enabled }}
78-
- --http-endpoint=localhost:{{ .Values.node.nodeDriverRegistrar.healthPort }}
77+
{{- if .Values.nodeDriverRegistrar.livenessProbe.enabled }}
78+
- --http-endpoint=localhost:{{ .Values.nodeDriverRegistrar.healthPort }}
7979
{{- end }}
8080
env:
8181
- name: DRIVER_REG_SOCK_PATH
@@ -90,20 +90,20 @@ spec:
9090
mountPath: /csi
9191
- name: registration-dir
9292
mountPath: /registration
93-
{{- if .Values.node.nodeDriverRegistrar.livenessProbe.enabled }}
93+
{{- if .Values.nodeDriverRegistrar.livenessProbe.enabled }}
9494
ports:
9595
- name: healthz
96-
containerPort: {{ .Values.node.nodeDriverRegistrar.healthPort }}
96+
containerPort: {{ .Values.nodeDriverRegistrar.healthPort }}
9797
protocol: TCP
9898
livenessProbe:
9999
httpGet:
100100
host: localhost
101101
path: /healthz
102102
port: healthz
103-
initialDelaySeconds: {{ .Values.node.nodeDriverRegistrar.livenessProbe.initialDelaySeconds }}
104-
timeoutSeconds: {{ .Values.node.nodeDriverRegistrar.livenessProbe.timeoutSeconds }}
105-
periodSeconds: {{ .Values.node.nodeDriverRegistrar.livenessProbe.periodSeconds }}
106-
failureThreshold: {{ .Values.node.nodeDriverRegistrar.livenessProbe.failureThreshold }}
103+
initialDelaySeconds: {{ .Values.nodeDriverRegistrar.livenessProbe.initialDelaySeconds }}
104+
timeoutSeconds: {{ .Values.nodeDriverRegistrar.livenessProbe.timeoutSeconds }}
105+
periodSeconds: {{ .Values.nodeDriverRegistrar.livenessProbe.periodSeconds }}
106+
failureThreshold: {{ .Values.nodeDriverRegistrar.livenessProbe.failureThreshold }}
107107
{{- end }}
108108
resources: {{- toYaml .Values.node.resources.nodeDriverRegistrar | nindent 12 }}
109109
securityContext:

charts/latest/csi-driver-nfs/values.yaml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -113,21 +113,22 @@ controller:
113113
cpu: 10m
114114
memory: 20Mi
115115

116+
nodeDriverRegistrar:
117+
healthPort: 19809
118+
livenessProbe:
119+
enabled: true
120+
initialDelaySeconds: 20
121+
timeoutSeconds: 10
122+
periodSeconds: 20
123+
failureThreshold: 2
124+
116125
node:
117126
name: csi-nfs-node
118127
dnsPolicy: ClusterFirstWithHostNet # available values: Default, ClusterFirstWithHostNet, ClusterFirst
119128
maxUnavailable: 1
120129
logLevel: 5
121130
livenessProbe:
122131
healthPort: 29653
123-
nodeDriverRegistrar:
124-
healthPort: 19809
125-
livenessProbe:
126-
enabled: true
127-
initialDelaySeconds: 20
128-
timeoutSeconds: 10
129-
periodSeconds: 20
130-
failureThreshold: 2
131132
affinity: {}
132133
nodeSelector: {}
133134
priorityClassName: system-cluster-critical

0 commit comments

Comments
 (0)