Skip to content

Commit d9e65c6

Browse files
committed
feat: add --timeout flag for node-driver-registrar to avoid race condition
Add configurable timeout for node-driver-registrar gRPC connection to the CSI driver socket. Default increased from 10s to 60s to prevent unnecessary container restarts when nfsplugin takes longer to initialize and create the CSI socket. Fixes #1065
1 parent 6f17b9b commit d9e65c6

4 files changed

Lines changed: 3 additions & 0 deletions

File tree

22 Bytes
Binary file not shown.

charts/latest/csi-driver-nfs/templates/csi-nfs-node.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ spec:
7474
- --v=2
7575
- --csi-address=/csi/csi.sock
7676
- --kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)
77+
- --timeout={{ .Values.nodeDriverRegistrar.timeout }}s
7778
{{- if .Values.nodeDriverRegistrar.livenessProbe.enabled }}
7879
- --http-endpoint=localhost:{{ .Values.nodeDriverRegistrar.healthPort }}
7980
{{- end }}

charts/latest/csi-driver-nfs/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ controller:
114114
memory: 20Mi
115115

116116
nodeDriverRegistrar:
117+
timeout: 60
117118
healthPort: 19809
118119
livenessProbe:
119120
enabled: true

deploy/v4.13.2/csi-nfs-node.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ spec:
5555
- --v=2
5656
- --csi-address=/csi/csi.sock
5757
- --kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)
58+
- --timeout=60s
5859
env:
5960
- name: DRIVER_REG_SOCK_PATH
6061
value: /var/lib/kubelet/plugins/csi-nfsplugin/csi.sock

0 commit comments

Comments
 (0)