Skip to content

Commit 6e24b64

Browse files
authored
Merge pull request #856 from aslafy-z/fix/scalar-quotas
fix: correct quotas on prometheus federation HA
2 parents cb72d73 + b41eb2a commit 6e24b64

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

Diff for: dashboards/resources/namespace.libsonnet

+4-4
Original file line numberDiff line numberDiff line change
@@ -131,13 +131,13 @@ local var = g.dashboard.variable;
131131

132132
prometheus.new(
133133
'${datasource}',
134-
'scalar(kube_resourcequota{%(clusterLabel)s="$cluster", namespace="$namespace", type="hard",resource="requests.cpu"})' % $._config
134+
'scalar(max(kube_resourcequota{%(clusterLabel)s="$cluster", namespace="$namespace", type="hard",resource="requests.cpu"}))' % $._config
135135
)
136136
+ prometheus.withLegendFormat('quota - requests'),
137137

138138
prometheus.new(
139139
'${datasource}',
140-
'scalar(kube_resourcequota{%(clusterLabel)s="$cluster", namespace="$namespace", type="hard",resource="limits.cpu"})' % $._config
140+
'scalar(max(kube_resourcequota{%(clusterLabel)s="$cluster", namespace="$namespace", type="hard",resource="limits.cpu"}))' % $._config
141141
)
142142
+ prometheus.withLegendFormat('quota - limits'),
143143
])
@@ -293,13 +293,13 @@ local var = g.dashboard.variable;
293293

294294
prometheus.new(
295295
'${datasource}',
296-
'scalar(kube_resourcequota{%(clusterLabel)s="$cluster", namespace="$namespace", type="hard",resource="requests.memory"})' % $._config
296+
'scalar(max(kube_resourcequota{%(clusterLabel)s="$cluster", namespace="$namespace", type="hard",resource="requests.memory"}))' % $._config
297297
)
298298
+ prometheus.withLegendFormat('quota - requests'),
299299

300300
prometheus.new(
301301
'${datasource}',
302-
'scalar(kube_resourcequota{%(clusterLabel)s="$cluster", namespace="$namespace", type="hard",resource="limits.memory"})' % $._config
302+
'scalar(max(kube_resourcequota{%(clusterLabel)s="$cluster", namespace="$namespace", type="hard",resource="limits.memory"}))' % $._config
303303
)
304304
+ prometheus.withLegendFormat('quota - limits'),
305305
])

Diff for: dashboards/resources/workload-namespace.libsonnet

+1-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ local var = g.dashboard.variable;
118118
local memRequestsQuery = std.strReplace(cpuRequestsQuery, 'cpu', 'memory');
119119
local memLimitsQuery = std.strReplace(cpuLimitsQuery, 'cpu', 'memory');
120120

121-
local cpuQuotaRequestsQuery = 'scalar(kube_resourcequota{%(clusterLabel)s="$cluster", namespace="$namespace", type="hard",resource=~"requests.cpu|cpu"})' % $._config;
121+
local cpuQuotaRequestsQuery = 'scalar(max(kube_resourcequota{%(clusterLabel)s="$cluster", namespace="$namespace", type="hard",resource=~"requests.cpu|cpu"}))' % $._config;
122122
local cpuQuotaLimitsQuery = std.strReplace(cpuQuotaRequestsQuery, 'requests.cpu|cpu', 'limits.cpu');
123123
local memoryQuotaRequestsQuery = std.strReplace(cpuQuotaRequestsQuery, 'requests.cpu|cpu', 'requests.memory|memory');
124124
local memoryQuotaLimitsQuery = std.strReplace(cpuQuotaRequestsQuery, 'requests.cpu|cpu', 'limits.memory');

0 commit comments

Comments
 (0)