Merge pull request #179 from mumoshu/more-validation-for-spot-fleet

Add missing validations for a node pool powered by Spot Fleet

Author: mumoshu

config/config.go

@@ -1105,6 +1105,14 @@ func (c WorkerDeploymentSettings) Valid() error {
 		return fmt.Errorf("number of user provided security groups must be less than or equal to 4 but was %d (actual EC2 limit is 5 but one of them is reserved for kube-aws) : %v", numSGs, sgRefs)
 	}
 
+	if c.SpotFleet.Enabled() && c.Experimental.AwsEnvironment.Enabled {
+		return fmt.Errorf("The experimental feature `awsEnvironment` assumes a node pool is managed by an ASG rather than a Spot Fleet.")
+	}
+
+	if c.SpotFleet.Enabled() && c.Experimental.WaitSignal.Enabled {
+		return fmt.Errorf("The experimental feature `waitSignal` assumes a node pool is managed by an ASG rather than a Spot Fleet.")
+	}
+
 	return nil
 }
 

nodepool/config/config_test.go

@@ -466,6 +466,30 @@ vpcId: vpc-1a2b3c4d
 vpcCIDR: "10.1.0.0/16"
 `,
 		},
+		{
+			context: "WithSpotFleetWithExperimentalAwsEnvironment",
+			configYaml: minimalValidConfigYaml + `
+worker:
+  spotFleet:
+    targetCapacity: 10
+experimental:
+  awsEnvironment:
+    enabled: true
+`,
+			expectedErrorMessage: "The experimental feature `awsEnvironment` assumes a node pool is managed by an ASG rather than a Spot Fleet.",
+		},
+		{
+			context: "WithSpotFleetWithExperimentalWaitSignal",
+			configYaml: minimalValidConfigYaml + `
+worker:
+  spotFleet:
+    targetCapacity: 10
+experimental:
+  waitSignal:
+    enabled: true
+`,
+			expectedErrorMessage: "The experimental feature `waitSignal` assumes a node pool is managed by an ASG rather than a Spot Fleet.",
+		},
 		{
 			context: "WithSpotFleetWithInvalidRootVolumeType",
 			configYaml: minimalValidConfigYaml + `