Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

Commit b6bb843

Browse files
authored
Merge pull request #432 from mumoshu/make-node-labels-ordering-stable
Make node labels ordering stable
2 parents 513e2b5 + ae9182f commit b6bb843

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

core/controlplane/config/config.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import (
1818
"github.com/coreos/kube-aws/model/derived"
1919
"github.com/coreos/kube-aws/netutil"
2020
yaml "gopkg.in/yaml.v2"
21+
"sort"
2122
)
2223

2324
const (
@@ -527,7 +528,13 @@ func (l NodeLabels) Enabled() bool {
527528
// Returns key=value pairs separated by ',' to be passed to kubelet's `--node-labels` flag
528529
func (l NodeLabels) String() string {
529530
labels := []string{}
530-
for k, v := range l {
531+
keys := []string{}
532+
for k, _ := range l {
533+
keys = append(keys, k)
534+
}
535+
sort.Strings(keys)
536+
for _, k := range keys {
537+
v := l[k]
531538
labels = append(labels, fmt.Sprintf("%s=%s", k, v))
532539
}
533540
return strings.Join(labels, ",")

0 commit comments

Comments
 (0)