fix: MaxPods is an optional AzureManagedMachinePool configuration

Author: jackfrancis

exp/api/v1beta1/azuremanagedmachinepool_webhook.go

@@ -193,8 +193,10 @@ func (r *AzureManagedMachinePool) validateLastSystemNodePool(cli client.Client)
 }
 
 func (r *AzureManagedMachinePool) validateMaxPods() error {
-	if to.Int32(r.Spec.MaxPods) < 10 || to.Int32(r.Spec.MaxPods) > 250 {
-		return errors.New("MaxPods must be between 10 and 250")
+	if r.Spec.MaxPods != nil {
+		if to.Int32(r.Spec.MaxPods) < 10 || to.Int32(r.Spec.MaxPods) > 250 {
+			return errors.New("MaxPods must be between 10 and 250")
+		}
 	}
 
 	return nil

exp/api/v1beta1/azuremanagedmachinepool_webhook_test.go

@@ -257,6 +257,13 @@ func TestAzureManagedMachinePool_ValidateCreate(t *testing.T) {
 			},
 			wantErr: false,
 		},
+		{
+			name: "valid - optional configuration not present",
+			ammp: &AzureManagedMachinePool{
+				Spec: AzureManagedMachinePoolSpec{},
+			},
+			wantErr: false,
+		},
 		{
 			name: "too many MaxPods",
 			ammp: &AzureManagedMachinePool{

templates/test/ci/cluster-template-prow-aks-multi-tenancy.yaml

@@ -101,7 +101,6 @@ metadata:
   name: agentpool1
   namespace: default
 spec:
-  maxPods: 24
   mode: User
   osDiskSizeGB: 1024
   sku: ${AZURE_NODE_MACHINE_TYPE}

templates/test/ci/prow-aks-multi-tenancy/kustomization.yaml

@@ -6,4 +6,3 @@ resources:
 patchesStrategicMerge:
   - ../patches/tags-aks.yaml
   - patches/maxpods-aks-agentpool0.yaml
-  - patches/maxpods-aks-agentpool1.yaml