You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: address code review findings in KubeRay e2e tests
- Use NestedFieldNoCopy+BeNumerically instead of NestedInt64 for
minCount assertion (JSON numbers are float64, not int64)
- Strengthen gang scheduling assertion to verify all-or-nothing:
at most 1 worker Running, >= 19 Pending (not just pendingCount > 0)
- Hardcode apiServer feature-gates consistently with controller-manager
and scheduler (remove K8S_FEATURE_GATES override that could cause
component feature gate mismatch)
// Gang scheduling all-or-nothing: with minCount=20 and insufficient resources,
522
+
// the scheduler should not schedule any new pods in the gang. At most 1 worker
523
+
// may remain Running from before the scale-up.
524
+
returnrunningCount<=1&&pendingCount>=19
525
+
}, e2eConfig.GetIntervals(specName, "wait-workload-ready")...).Should(BeTrue(), "expected gang scheduling to prevent new workers from Running (all-or-nothing)")
526
+
Logf("Gang scheduling verified: at most 1 worker Running, rest Pending (all-or-nothing)")
520
527
521
528
By("scaling workers back to 1 replica to verify recovery")
0 commit comments