add uts

Author: arshadd-b

cloud/scope/powervs_cluster_test.go

@@ -1765,6 +1765,74 @@ func TestCreateLoadbalancer(t *testing.T) {
 		}, nil, nil)
 		mockgt.EXPECT().AttachTag(gomock.Any()).Return(nil, nil, nil)
 
+		loadBalancerStatus, err := clusterScope.createLoadBalancer(lb)
+		g.Expect(err).To(BeNil())
+		g.Expect(loadBalancerStatus.State).To(BeEquivalentTo(infrav1beta2.VPCLoadBalancerStateActive))
+		g.Expect(loadBalancerStatus.ControllerCreated).To(Equal(ptr.To(true)))
+		g.Expect(loadBalancerStatus.Hostname).To(Equal(ptr.To("test-lb-hostname")))
+	})
+	t.Run("When IBMVPCClient client CreateLoadBalancer successfully creates load balancer in cloud but tagging load balancer fails", func(*testing.T) {
+		g := NewWithT(t)
+		setup(t)
+		t.Cleanup(teardown)
+
+		clusterAPIServerPort := int32(9090)
+		clusterScope := PowerVSClusterScope{
+			IBMVPCClient:        mockVpc,
+			GlobalTaggingClient: mockgt,
+			IBMPowerVSCluster: &infrav1beta2.IBMPowerVSCluster{
+				Spec: infrav1beta2.IBMPowerVSClusterSpec{
+
+					ResourceGroup: &infrav1beta2.IBMPowerVSResourceReference{
+						ID: ptr.To("test-resource-gid"),
+					},
+					LoadBalancers: []infrav1beta2.VPCLoadBalancerSpec{
+						{
+							Name: "test-lb",
+							ID:   nil,
+						},
+					},
+					VPCSubnets: []infrav1beta2.Subnet{
+						{
+							Name: ptr.To("test-subnet"),
+							ID:   ptr.To("test-subnetid"),
+						},
+					},
+				},
+				Status: infrav1beta2.IBMPowerVSClusterStatus{
+					VPCSubnet: map[string]infrav1beta2.ResourceReference{
+						"test-subnet": {
+							ID: ptr.To("test-resource-reference-id"),
+						},
+					},
+				},
+			},
+			Cluster: &capiv1beta1.Cluster{
+				Spec: capiv1beta1.ClusterSpec{
+					ClusterNetwork: &capiv1beta1.ClusterNetwork{
+						APIServerPort: &clusterAPIServerPort,
+					},
+				},
+			},
+		}
+
+		lb := infrav1beta2.VPCLoadBalancerSpec{
+			Name: "test-lb",
+			AdditionalListeners: []infrav1beta2.AdditionalListenerSpec{
+				{
+					Port: int64(9090),
+				},
+			},
+		}
+
+		mockVpc.EXPECT().CreateLoadBalancer(gomock.Any()).Return(&vpcv1.LoadBalancer{
+			ID:                 ptr.To("test-lb-id"),
+			ProvisioningStatus: ptr.To("active"),
+			Hostname:           ptr.To("test-lb-hostname"),
+			CRN:                ptr.To("lb-crn"),
+		}, nil, nil)
+		mockgt.EXPECT().AttachTag(gomock.Any()).Return(nil, nil, fmt.Errorf("failed to tag load balancer"))
+
 		loadBalancerStatus, err := clusterScope.createLoadBalancer(lb)
 		g.Expect(err).To(BeNil())
 		g.Expect(loadBalancerStatus.State).To(BeEquivalentTo(infrav1beta2.VPCLoadBalancerStateActive))
@@ -2750,6 +2818,28 @@ func TestPowerVSScopeCreateVPC(t *testing.T) {
 		g.Expect(vpcID).To(Equal(vpcOutput.ID))
 	})
 
+	t.Run("When create VPC is successful but tagging vpc fails", func(t *testing.T) {
+		g := NewWithT(t)
+		setup(t)
+		t.Cleanup(teardown)
+
+		clusterScope := PowerVSClusterScope{
+			IBMVPCClient:        mockVPC,
+			GlobalTaggingClient: mockgt,
+			Cluster:             &capiv1beta1.Cluster{Spec: capiv1beta1.ClusterSpec{ClusterNetwork: nil}},
+			IBMPowerVSCluster: &infrav1beta2.IBMPowerVSCluster{Spec: infrav1beta2.IBMPowerVSClusterSpec{
+				ResourceGroup: &infrav1beta2.IBMPowerVSResourceReference{ID: ptr.To("resourceGroupID")}}},
+		}
+		vpcOutput := &vpcv1.VPC{Name: ptr.To("VPCName"), ID: ptr.To("vpcID"), DefaultSecurityGroup: &vpcv1.SecurityGroupReference{ID: ptr.To("DefaultSecurityGroupID")}}
+		mockVPC.EXPECT().CreateVPC(gomock.Any()).Return(vpcOutput, nil, nil)
+		mockgt.EXPECT().AttachTag(gomock.Any()).Return(nil, nil, fmt.Errorf("AttachTag returns error"))
+		mockVPC.EXPECT().CreateSecurityGroupRule(gomock.Any()).Return(nil, nil, nil)
+
+		vpcID, err := clusterScope.createVPC()
+		g.Expect(err).To(BeNil())
+		g.Expect(vpcID).To(Equal(vpcOutput.ID))
+	})
+
 	t.Run("When resourceGroupID is not nil and CreateSecurityGroupRule returns error", func(t *testing.T) {
 		g := NewWithT(t)
 		setup(t)
@@ -4083,6 +4173,31 @@ func TestCreateVPCSubnet(t *testing.T) {
 		g.Expect(subnetID).To(Equal(subnet1Details.ID))
 		g.Expect(err).To(BeNil())
 	})
+	t.Run("When createVPCSubnet returns success but tagging subnet fails", func(t *testing.T) {
+		g := NewWithT(t)
+		setup(t)
+		t.Cleanup(teardown)
+
+		clusterScope := PowerVSClusterScope{
+			Cluster:             &capiv1beta1.Cluster{},
+			IBMVPCClient:        mockVPC,
+			GlobalTaggingClient: mockgt,
+			IBMPowerVSCluster: &infrav1beta2.IBMPowerVSCluster{
+				Spec: infrav1beta2.IBMPowerVSClusterSpec{
+					ResourceGroup: &infrav1beta2.IBMPowerVSResourceReference{ID: ptr.To("resourceGroupID")},
+				},
+				Status: infrav1beta2.IBMPowerVSClusterStatus{VPC: &infrav1beta2.ResourceReference{ID: ptr.To("vpcID")}},
+			},
+		}
+		subnet := infrav1beta2.Subnet{Name: ptr.To("ClusterName-vpcsubnet-eu-de-1"), Zone: ptr.To("eu-de-1")}
+		subnet1Details := &vpcv1.Subnet{ID: ptr.To("subnet1ID"), Name: ptr.To("ClusterName-vpcsubnet-eu-de-1"), CRN: ptr.To("subnet-crn")}
+
+		mockVPC.EXPECT().CreateSubnet(gomock.Any()).Return(subnet1Details, nil, nil)
+		mockgt.EXPECT().AttachTag(gomock.Any()).Return(nil, nil, fmt.Errorf("error attching subnet"))
+		subnetID, err := clusterScope.createVPCSubnet(subnet)
+		g.Expect(subnetID).To(Equal(subnet1Details.ID))
+		g.Expect(err).To(BeNil())
+	})
 	t.Run("When zone is not set and createVPCSubnet returns success", func(t *testing.T) {
 		g := NewWithT(t)
 		setup(t)
@@ -7263,6 +7378,53 @@ func TestCreateTransitGateway(t *testing.T) {
 		g.Expect(*clusterScope.IBMPowerVSCluster.Status.TransitGateway.VPCConnection.ControllerCreated).To(BeTrue())
 		g.Expect(err).To(BeNil())
 	})
+
+	t.Run("When TransitGateway is created but tagging TransitGateway fails", func(t *testing.T) {
+		g := NewWithT(t)
+		setup(t)
+		t.Cleanup(teardown)
+
+		clusterScope := PowerVSClusterScope{
+			Cluster:              &capiv1beta1.Cluster{},
+			TransitGatewayClient: mockTransitGateway,
+			IBMVPCClient:         mockVPC,
+			ResourceClient:       mockResourceController,
+			GlobalTaggingClient:  mockgt,
+			IBMPowerVSCluster: &infrav1beta2.IBMPowerVSCluster{
+				Spec: infrav1beta2.IBMPowerVSClusterSpec{
+					TransitGateway: &infrav1beta2.TransitGateway{
+						GlobalRouting: ptr.To(true),
+					},
+					ResourceGroup: &infrav1beta2.IBMPowerVSResourceReference{ID: ptr.To("resourceGroupID")},
+					Zone:          ptr.To("zone-ID"),
+					VPC:           &infrav1beta2.VPCResourceReference{Region: ptr.To("region")},
+				},
+				Status: infrav1beta2.IBMPowerVSClusterStatus{
+					ServiceInstance: &infrav1beta2.ResourceReference{
+						ID: ptr.To("serviceInstanceID"),
+					},
+					VPC: &infrav1beta2.ResourceReference{
+						ID: ptr.To("vpcID"),
+					},
+				},
+			},
+		}
+
+		mockTransitGateway.EXPECT().CreateTransitGateway(gomock.Any()).Return(&tgapiv1.TransitGateway{ID: ptr.To("transitGatewayID"), Name: ptr.To("transitGatewayName"), Status: ptr.To(string(infrav1beta2.TransitGatewayStateAvailable))}, nil, nil)
+		mockgt.EXPECT().AttachTag(gomock.Any()).Return(nil, nil, fmt.Errorf("failed to tag transitGateway"))
+		mockVPC.EXPECT().GetVPC(gomock.Any()).Return(&vpcv1.VPC{CRN: ptr.To("crn")}, nil, nil)
+		mockResourceController.EXPECT().GetResourceInstance(gomock.Any()).Return(&resourcecontrollerv2.ResourceInstance{CRN: ptr.To("crn")}, nil, nil)
+		mockTransitGateway.EXPECT().CreateTransitGatewayConnection(gomock.Any()).Return(&tgapiv1.TransitGatewayConnectionCust{ID: ptr.To("pvs-connID")}, nil, nil)
+		mockTransitGateway.EXPECT().CreateTransitGatewayConnection(gomock.Any()).Return(&tgapiv1.TransitGatewayConnectionCust{ID: ptr.To("vpc-connID")}, nil, nil)
+		err := clusterScope.createTransitGateway()
+		g.Expect(*clusterScope.IBMPowerVSCluster.Status.TransitGateway.ID).To(BeEquivalentTo("transitGatewayID"))
+		g.Expect(*clusterScope.IBMPowerVSCluster.Status.TransitGateway.ControllerCreated).To(BeTrue())
+		g.Expect(*clusterScope.IBMPowerVSCluster.Status.TransitGateway.PowerVSConnection.ID).To(BeEquivalentTo("pvs-connID"))
+		g.Expect(*clusterScope.IBMPowerVSCluster.Status.TransitGateway.PowerVSConnection.ControllerCreated).To(BeTrue())
+		g.Expect(*clusterScope.IBMPowerVSCluster.Status.TransitGateway.VPCConnection.ID).To(BeEquivalentTo("vpc-connID"))
+		g.Expect(*clusterScope.IBMPowerVSCluster.Status.TransitGateway.VPCConnection.ControllerCreated).To(BeTrue())
+		g.Expect(err).To(BeNil())
+	})
 }
 
 func makePowerVSClusterScope(mockTransitGateway *tgmock.MockTransitGateway, mockVPC *mock.MockVpc, mockResourceController *mockRC.MockResourceController) PowerVSClusterScope {
@@ -9621,6 +9783,33 @@ func TestCreateVPCSecurityGroup(t *testing.T) {
 		g.Expect(*sg).To(BeEquivalentTo("securityGroupID"))
 		g.Expect(err).To(BeNil())
 	})
+
+	t.Run("When SecurityGroup is created successfully but tagging SecurityGroup fails", func(t *testing.T) {
+		g := NewWithT(t)
+		setup(t)
+		t.Cleanup(teardown)
+		clusterScope := PowerVSClusterScope{
+			Cluster:             &capiv1beta1.Cluster{},
+			IBMVPCClient:        mockVPC,
+			GlobalTaggingClient: mockgt,
+			IBMPowerVSCluster: &infrav1beta2.IBMPowerVSCluster{
+				Spec: infrav1beta2.IBMPowerVSClusterSpec{
+					VPCSecurityGroups: append([]infrav1beta2.VPCSecurityGroup{}, infrav1beta2.VPCSecurityGroup{
+						Name: ptr.To("securityGroupName"),
+					}),
+					ResourceGroup: &infrav1beta2.IBMPowerVSResourceReference{
+						ID: ptr.To("resourceGroupID"),
+					},
+				},
+			},
+		}
+
+		mockVPC.EXPECT().CreateSecurityGroup(gomock.Any()).Return(&vpcv1.SecurityGroup{ID: ptr.To("securityGroupID"), CRN: ptr.To("sg-crn")}, nil, nil)
+		mockgt.EXPECT().AttachTag(gomock.Any()).Return(nil, nil, fmt.Errorf("failed to tag SecurityGroup"))
+		sg, err := clusterScope.createVPCSecurityGroup(clusterScope.IBMPowerVSCluster.Spec.VPCSecurityGroups[0])
+		g.Expect(*sg).To(BeEquivalentTo("securityGroupID"))
+		g.Expect(err).To(BeNil())
+	})
 	t.Run("When SecurityGroup returns error", func(t *testing.T) {
 		g := NewWithT(t)
 		setup(t)