Update cmd/clusterctl/cmd/plugin_test.go

Co-authored-by: Christian Schlotter <[email protected]>

Author: dmvolod

cmd/clusterctl/cmd/plugin_test.go

@@ -37,6 +37,14 @@ const (
 func Test_plugin(t *testing.T) {
 	if os.Getenv(forkEnvVar) == "" {
 		g := NewWithT(t)
+		tmpDir := os.TempDir()
+		defer os.Remove(tmpDir)
+
+		// Create a bash based plugin used for the test which gets added to the PATH variable.
+		pluginPath := filepath.Join(tmpDir, "clusterctl-foo")
+		pathVar := os.Getenv("PATH")
+		g.Expect(os.WriteFile(pluginPath, []byte(pluginCode), 0755)).To(Succeed()) //nolint:gosec
+
 		tt := []struct {
 			name     string
 			command  string
@@ -52,19 +60,11 @@ func Test_plugin(t *testing.T) {
 				expected: "1.0.0",
 			},
 		}
-
-		tmpDir := os.TempDir()
-		defer os.Remove(tmpDir)
-
-		pluginPath := filepath.Join(tmpDir, "clusterctl-foo")
-		path := os.Getenv("PATH")
-		g.Expect(os.WriteFile(pluginPath, []byte(pluginCode), 0755)).To(Succeed()) //nolint:gosec
-
 		for _, tc := range tt {
 			t.Run(tc.name, func(t *testing.T) {
 				g := NewWithT(t)
-				stdout, _, err := runForkTest(t.Name(), fmt.Sprintf("%s=%s", pluginCommandEnvVar, tc.command), fmt.Sprintf("PATH=%s:%s", tmpDir, path))
-				g.Expect(err).NotTo(HaveOccurred())
+				stdout, _, err := runForkTest(t.Name(), fmt.Sprintf("%s=%s", pluginCommandEnvVar, tc.command), fmt.Sprintf("PATH=%s:%s", tmpDir, pathVar))
+				g.Expect(err).To(Succeed())
 				g.Expect(stdout).To(ContainSubstring(tc.expected))
 			})
 		}