Validate conditions at the end of e2e tests

[sbueringer]

We recently noticed that after a CAPI upgrade some conditions didn't look as expected (e.g. Available was false).

We fixed the issue and then added validation of some conditions to the clusterctl upgrade tests in: #11948

So now we are checking Ready and Available conditions on Clusters and Machines.

We should add the same check to the end of other e2e tests as well (maybe even all or most of them).

[sivchari]

Hi @sbueringer I'm interested in try this.
I want to confirm tasks that I should do to increase resolution.
Presumably, all tests need to add this check. And these print PASSED! at the end now.
At the end of e2e what you mean is before PASSED! log, right ? So Is it that I add this checking before it ?

[chrischdi]

This issue is about to add this part of the above linked PR:

			Byf("[%d] Verify v1beta2 Available and Ready conditions (if exist) to be true for Cluster and Machines", i)
			verifyV1Beta2ConditionsTrue(ctx, managementClusterProxy.GetClient(), workloadCluster.Name, workloadCluster.Namespace,
				[]string{clusterv1.AvailableV1Beta2Condition, clusterv1.ReadyV1Beta2Condition})

https://github.com/kubernetes-sigs/cluster-api/pull/11948/files#diff-58053a2b3d2702f3d220e1ec0a51199823c49f9732a7baca054ef258641df7fdR709-R712

Also to other e2e tests (and maybe move it to one of our e2e packages)

[chrischdi]

/help

[k8s-ci-robot]

@chrischdi:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sivchari]

/assign