-
Notifications
You must be signed in to change notification settings - Fork 1.4k
📖 ci-signal: clarified timing for dropping n-3 release support in setup steps #12057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
📖 ci-signal: clarified timing for dropping n-3 release support in setup steps #12057
Conversation
/kind documentation |
/area documentation |
Once the new minor release (e.g., `v1.8.0`) has been officially cut, perform the following cleanup: | ||
|
||
- Remove old release branches and unused versions from the `cluster-api-prowjob-gen.yaml` file in [test-infra](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api/) according to our policy documented in [Support and guarantees](../../../../CONTRIBUTING.md#support-and-guarantees). | ||
As we just added `release-1.8`, we can now drop test coverage for the `release-1.5` branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we just added `release-1.8`, we can now drop test coverage for the `release-1.5` branch. | |
We can now drop test coverage for branaches out of support (e.g. `release-1.5`). |
### Post-release cleanup | ||
Once the new minor release (e.g., `v1.8.0`) has been officially cut, perform the following cleanup: | ||
|
||
- Remove old release branches and unused versions from the `cluster-api-prowjob-gen.yaml` file in [test-infra](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api/) according to our policy documented in [Support and guarantees](../../../../CONTRIBUTING.md#support-and-guarantees). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this link "../../../../CONTRIBUTING.md#support-and-guarantees" is broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabriziopandini Can you please share where this should link to? I think somewhere in versions.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbueringer apologies for the delay i was away - should I link it to here: https://github.com/shecodesmagic/cluster-api/blob/main/docs/book/src/reference/versions.md#cluster-api-release-vs-api-versions
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm, thank you! Could you squash the commits?
… steps added post release cleanup step updated post-release clean up + release tracking tasks fix link
09b8934
to
4c52770
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: bc8264c3e81b4a5bbfad61c74adc39fd4efff9eb
|
What this PR does / why we need it:
This PR updates the CI Signal handbook to clarify the timing for dropping support for n-3 release branches during the new release setup process.
Previously, the instructions implied that support for n-3 (e.g., release-1.7 during the v1.10 cycle) should be removed during the setup phase. However, during the v1.10 release, the team aligned on delaying this step until after the new minor release (e.g., v1.10.0) has been officially cut.
This update ensures consistency with current team practices and avoids premature removal of test coverage for supported versions.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #12025