Skip to content

📖 ci-signal: clarified timing for dropping n-3 release support in setup steps #12057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shecodesmagic
Copy link

What this PR does / why we need it:
This PR updates the CI Signal handbook to clarify the timing for dropping support for n-3 release branches during the new release setup process.

Previously, the instructions implied that support for n-3 (e.g., release-1.7 during the v1.10 cycle) should be removed during the setup phase. However, during the v1.10 release, the team aligned on delaying this step until after the new minor release (e.g., v1.10.0) has been officially cut.

This update ensures consistency with current team practices and avoids premature removal of test coverage for supported versions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #12025

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2025
@shecodesmagic
Copy link
Author

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 6, 2025
@shecodesmagic
Copy link
Author

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation and removed do-not-merge/needs-area PR is missing an area label labels Apr 6, 2025
@shecodesmagic shecodesmagic changed the title 📖 ci-signal: clarified timing for dropping n-3 release support in setup syeps 📖 ci-signal: clarified timing for dropping n-3 release support in setup steps Apr 6, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2025
@shecodesmagic shecodesmagic requested a review from sbueringer April 8, 2025 01:37
Once the new minor release (e.g., `v1.8.0`) has been officially cut, perform the following cleanup:

- Remove old release branches and unused versions from the `cluster-api-prowjob-gen.yaml` file in [test-infra](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api/) according to our policy documented in [Support and guarantees](../../../../CONTRIBUTING.md#support-and-guarantees).
As we just added `release-1.8`, we can now drop test coverage for the `release-1.5` branch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As we just added `release-1.8`, we can now drop test coverage for the `release-1.5` branch.
We can now drop test coverage for branaches out of support (e.g. `release-1.5`).

### Post-release cleanup
Once the new minor release (e.g., `v1.8.0`) has been officially cut, perform the following cleanup:

- Remove old release branches and unused versions from the `cluster-api-prowjob-gen.yaml` file in [test-infra](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api/) according to our policy documented in [Support and guarantees](../../../../CONTRIBUTING.md#support-and-guarantees).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this link "../../../../CONTRIBUTING.md#support-and-guarantees" is broken

Copy link
Member

@sbueringer sbueringer Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabriziopandini Can you please share where this should link to? I think somewhere in versions.md

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm, thank you! Could you squash the commits?

… steps

added post release cleanup step

updated post-release clean up + release tracking tasks

fix link
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bc8264c3e81b4a5bbfad61c74adc39fd4efff9eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ci-signal handbook to reflect updated process for dropping unsupported versions
4 participants