Bump to golangci-lint v2

[sivchari]

golangci-lint v2 has already been launched. So let's migrate it from v1 to v2 .

The official documentation is broken (I don't know why it is broken), so I pasted the link of author's blog.
ref: https://ldez.github.io/blog/2025/03/23/golangci-lint-v2/

/area ci
/kind feature
/help

[k8s-ci-robot]

@sivchari:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

golangci-lint v2 has already been launched. So let's migrate it from v1 to v2 .

/area ci
/kind feature
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

This issue is currently awaiting triage.

If CAPI contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[chrischdi]

Yeah, we should tackle this at some point.

Golangci-lint did a great job in helping by adding a migration command.

However it needs some manual work to:

• preserve our comments
• take a look what changes.

Findings on a first view:

• removed linters
  • tenv # using os.Setenv instead of t.Setenv in test
• linters merged into staticcheck
  • stylecheck
  • gosimple
• not linters, but formatters now:
  • gci # ensures imports are organized
  • gofmt # warns about incorrect use of fmt functions
  • goimports # import formatting

In best case we get this done without any findings to fix, while not having to add new exclusions.

[sivchari]

golangci-lint provides migration guide, so almost migration will be done to use it. And we can replace tenv analyzer with usetesting analyzer.
I'll tackle it.
/assign