🌱 Bump golangci-lint v2 #12088
Open
🌱 Bump golangci-lint v2 #12088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
needs-rebase
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
sivchari
force-pushed
the
migrate-golangci-lint-v2
branch
2 times, most recently
from
d79565d to
de82fdf
Compare
k8s-ci-robot
removed
the
needs-rebase
sivchari
force-pushed
the
migrate-golangci-lint-v2
branch
6 times, most recently
from
2b74f5d to
988c2a5
Compare
k8s-ci-robot
added
size/XXL
sivchari
commented
Apr 13, 2025
.golangci.yml
Outdated
| text: 'SA1019: feature.ClusterResourceSet is deprecated: ClusterResourceSet feature is now GA and the corresponding feature flag will be removed in 1.12 release.' | ||
| - linters: | ||
| - staticcheck | ||
| text: 'SA1019: .* is deprecated: This field is deprecated and is going to be removed when support for v1beta1 will be dropped.' |
There was a problem hiding this comment.
I only added this exclusive rule. The diagnostic should be reported before this PR, but prow couldn't collect it somehow.
So it's not problem to add new one.
There was a problem hiding this comment.
I think this was covered before via:
text: "SA1019: .*\\.Deprecated\\.V1Beta1.* is deprecated"
|
/assign @chrischdi |
sivchari
force-pushed
the
migrate-golangci-lint-v2
branch
from
988c2a5 to
d183f07
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chrischdi
reviewed
Apr 14, 2025
Makefile
Outdated
| @@ -160,9 +160,9 @@ GINKGO := $(abspath $(TOOLS_BIN_DIR)/$(GINKGO_BIN)-$(GINKGO_VER)) | |||
| GINKGO_PKG := github.com/onsi/ginkgo/v2/ginkgo | |||
|
|
|||
| GOLANGCI_LINT_BIN := golangci-lint | |||
| GOLANGCI_LINT_VER := $(shell cat .github/workflows/pr-golangci-lint.yaml | grep [[:space:]]version: | sed 's/.*version: //') | |||
| GOLANGCI_LINT_VER := v2.0.2 | |||
There was a problem hiding this comment.
Let's revert this if possible and also use the native action (when not running kubeapilinter), because its visualization is a bit better.
sivchari
force-pushed
the
migrate-golangci-lint-v2
branch
from
d183f07 to
8025ba2
Compare
sivchari
force-pushed
the
migrate-golangci-lint-v2
branch
from
7e874af to
15b826a
Compare
k8s-ci-robot
added
the
needs-rebase
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
sivchari
force-pushed
the
migrate-golangci-lint-v2
branch
from
15b826a to
25673d5
Compare
k8s-ci-robot
removed
the
needs-rebase
Signed-off-by: sivchari <[email protected]>
chrischdi
reviewed
Apr 16, 2025
chrischdi
added
the
tide/merge-method-squash
chrischdi
reviewed
Apr 16, 2025
.golangci.yml
Outdated
Comment on lines
264
to
266
| - linters: | ||
| - staticcheck | ||
| text: 'SA1019: .* is deprecated: This field is deprecated and is going to be removed when support for v1beta1 will be dropped.' |
There was a problem hiding this comment.
Suggested change
| - linters: | |
| - staticcheck | |
| text: 'SA1019: .* is deprecated: This field is deprecated and is going to be removed when support for v1beta1 will be dropped.' | |
| # v1Beta1 deprecated fields | |
| - linters: | |
| - staticcheck | |
| text: 'SA1019: .*\.Deprecated\.V1Beta1.* is deprecated' |
Let's keep the old regex here :-)
Signed-off-by: sivchari <[email protected]>
sivchari
force-pushed
the
migrate-golangci-lint-v2
branch
from
2702f96 to
8530749
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: b95b8a4fa5432971a53d4acd8666d30638a42903
|
|
/assign @fabriziopandini |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
golangci-lint v2 is already released and it's so helpful to maintain codebase until now and from now on, so let's migrate it from v1 to v2.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #12087
/kind cleanup
/kind bug
/area ci